-
Notifications
You must be signed in to change notification settings - Fork 1
Open
Labels
enhancementNew feature or requestNew feature or request
Description
Summary
workflows.py:17 defines def __init__(self, *args, **kwargs) which passes everything through to the parent WorkflowRemediation. This loses all type information and IDE support (autocomplete, type checking, documentation hover).
Current Behavior
def __init__(self, *args, **kwargs):
super().__init__(*args, **kwargs)Users cannot see what parameters are expected without reading the parent class source code. mypy also cannot validate constructor arguments.
Suggested Fix
Explicitly declare the parameters that WorkflowRemediation expects:
def __init__(
self,
running_config: HConfig,
generated_config: HConfig,
...
) -> None:
super().__init__(running_config=running_config, generated_config=generated_config, ...)This also provides a natural place to add the prompt_template parameter (see related issue).
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or request