Skip to content

Suggestion - more unit test freindly #30

@ksteinmetz

Description

@ksteinmetz

Hi,
I happened on this great implementation while trying to get our code to talk to slack.
We had most of the basics in our own code, so this made sense.

While trying to unit test our code interface, I found phpunit can not mock your \Nexy\Slack\Client and \Nexy\Slack\Message classes, because they are marked Final.

It would be great if there was a simple interface that the Client and Message could implement so that your code can remain final and it is easy to mock your client and message classes through the interface. Then your code would be even more friendly.

Thanks and keep up the great work

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions