diff --git a/change/@ni-nimble-components-57d78934-1a89-4568-a6e1-180f14595025.json b/change/@ni-nimble-components-57d78934-1a89-4568-a6e1-180f14595025.json new file mode 100644 index 0000000000..3a83fd690e --- /dev/null +++ b/change/@ni-nimble-components-57d78934-1a89-4568-a6e1-180f14595025.json @@ -0,0 +1,7 @@ +{ + "type": "patch", + "comment": "Fix import syntax to obey new lint rule", + "packageName": "@ni/nimble-components", + "email": "jattasNI@users.noreply.github.com", + "dependentChangeType": "patch" +} diff --git a/change/@ni-nimble-react-6fd71e86-eb92-4a70-a873-a1eeac0be0ba.json b/change/@ni-nimble-react-6fd71e86-eb92-4a70-a873-a1eeac0be0ba.json new file mode 100644 index 0000000000..dabf63e8f4 --- /dev/null +++ b/change/@ni-nimble-react-6fd71e86-eb92-4a70-a873-a1eeac0be0ba.json @@ -0,0 +1,7 @@ +{ + "type": "patch", + "comment": "Fix import syntax to obey new lint rule", + "packageName": "@ni/nimble-react", + "email": "jattasNI@users.noreply.github.com", + "dependentChangeType": "patch" +} diff --git a/change/@ni-spright-angular-ad5f9ee0-9a6f-4df6-8395-1b0635903734.json b/change/@ni-spright-angular-ad5f9ee0-9a6f-4df6-8395-1b0635903734.json new file mode 100644 index 0000000000..a74f3d09bb --- /dev/null +++ b/change/@ni-spright-angular-ad5f9ee0-9a6f-4df6-8395-1b0635903734.json @@ -0,0 +1,7 @@ +{ + "type": "patch", + "comment": "Fix import syntax to obey new lint rule", + "packageName": "@ni/spright-angular", + "email": "jattasNI@users.noreply.github.com", + "dependentChangeType": "patch" +} diff --git a/change/@ni-spright-components-7b1e3ccd-95a0-47fc-b4a2-2fc604096f99.json b/change/@ni-spright-components-7b1e3ccd-95a0-47fc-b4a2-2fc604096f99.json new file mode 100644 index 0000000000..2de059f291 --- /dev/null +++ b/change/@ni-spright-components-7b1e3ccd-95a0-47fc-b4a2-2fc604096f99.json @@ -0,0 +1,7 @@ +{ + "type": "patch", + "comment": "Fix import syntax to obey new lint rule", + "packageName": "@ni/spright-components", + "email": "jattasNI@users.noreply.github.com", + "dependentChangeType": "patch" +} diff --git a/packages/angular-workspace/spright-angular/chat/input/spright-chat-input.directive.ts b/packages/angular-workspace/spright-angular/chat/input/spright-chat-input.directive.ts index 36dddcce00..e29f9dd225 100644 --- a/packages/angular-workspace/spright-angular/chat/input/spright-chat-input.directive.ts +++ b/packages/angular-workspace/spright-angular/chat/input/spright-chat-input.directive.ts @@ -1,6 +1,6 @@ import { Directive, ElementRef, Input, Renderer2 } from '@angular/core'; import { type ChatInput, chatInputTag } from '@ni/spright-components/dist/esm/chat/input'; -import { type ChatInputSendEventDetail } from '@ni/spright-components/dist/esm/chat/input/types'; +import type { ChatInputSendEventDetail } from '@ni/spright-components/dist/esm/chat/input/types'; export type { ChatInput }; export type { ChatInputSendEventDetail }; diff --git a/packages/eslint-config-nimble/typescript.js b/packages/eslint-config-nimble/typescript.js index 06b43d163e..a514a606e7 100644 --- a/packages/eslint-config-nimble/typescript.js +++ b/packages/eslint-config-nimble/typescript.js @@ -10,6 +10,7 @@ export const typescriptNimbleConfigOverrides = defineConfig([ jsdoc, }, rules: { + '@typescript-eslint/no-import-type-side-effects': 'error', // Require non-empty JSDoc comment on class declarations 'jsdoc/require-jsdoc': [ 'error', diff --git a/packages/nimble-components/src/breadcrumb/testing/breadcrumb.pageobject.ts b/packages/nimble-components/src/breadcrumb/testing/breadcrumb.pageobject.ts index 9c20ba437c..0760a3dd28 100644 --- a/packages/nimble-components/src/breadcrumb/testing/breadcrumb.pageobject.ts +++ b/packages/nimble-components/src/breadcrumb/testing/breadcrumb.pageobject.ts @@ -1,7 +1,7 @@ import type { Button } from '../../button'; import { waitForUpdatesAsync } from '../../testing/async-helpers'; import { waitTimeout } from '../../utilities/testing/component'; -import { type Breadcrumb } from '..'; +import type { Breadcrumb } from '..'; import { breadcrumbItemTag } from '../../breadcrumb-item'; /** diff --git a/packages/react-workspace/nimble-react/src/menu-button/index.ts b/packages/react-workspace/nimble-react/src/menu-button/index.ts index 64f8b1d41e..e22fec601a 100644 --- a/packages/react-workspace/nimble-react/src/menu-button/index.ts +++ b/packages/react-workspace/nimble-react/src/menu-button/index.ts @@ -1,5 +1,5 @@ import { MenuButton, menuButtonTag } from '@ni/nimble-components/dist/esm/menu-button'; -import { type MenuButtonToggleEventDetail } from '@ni/nimble-components/dist/esm/menu-button/types'; +import type { MenuButtonToggleEventDetail } from '@ni/nimble-components/dist/esm/menu-button/types'; import { wrap, type EventName } from '../utilities/react-wrapper'; import type { MenuItemChangeEvent } from '../menu-item'; diff --git a/packages/react-workspace/nimble-react/src/select/index.ts b/packages/react-workspace/nimble-react/src/select/index.ts index cd6bd273c6..3ece4dc2af 100644 --- a/packages/react-workspace/nimble-react/src/select/index.ts +++ b/packages/react-workspace/nimble-react/src/select/index.ts @@ -1,5 +1,5 @@ import { Select, selectTag } from '@ni/nimble-components/dist/esm/select'; -import { type SelectFilterInputEventDetail } from '@ni/nimble-components/dist/esm/select/types'; +import type { SelectFilterInputEventDetail } from '@ni/nimble-components/dist/esm/select/types'; import { wrap, type EventName } from '../utilities/react-wrapper'; export { selectTag }; diff --git a/packages/react-workspace/nimble-react/src/table-column/menu-button/index.ts b/packages/react-workspace/nimble-react/src/table-column/menu-button/index.ts index 4f5253fea2..6ffcbc9577 100644 --- a/packages/react-workspace/nimble-react/src/table-column/menu-button/index.ts +++ b/packages/react-workspace/nimble-react/src/table-column/menu-button/index.ts @@ -1,5 +1,5 @@ import { TableColumnMenuButton, tableColumnMenuButtonTag } from '@ni/nimble-components/dist/esm/table-column/menu-button'; -import { type MenuButtonColumnToggleEventDetail } from '@ni/nimble-components/dist/esm/table-column/menu-button/types'; +import type { MenuButtonColumnToggleEventDetail } from '@ni/nimble-components/dist/esm/table-column/menu-button/types'; import { wrap, type EventName } from '../../utilities/react-wrapper'; export { tableColumnMenuButtonTag }; diff --git a/packages/spright-components/src/chat/message/outbound/template.ts b/packages/spright-components/src/chat/message/outbound/template.ts index 59452b860a..412311c590 100644 --- a/packages/spright-components/src/chat/message/outbound/template.ts +++ b/packages/spright-components/src/chat/message/outbound/template.ts @@ -1,7 +1,5 @@ import { html, ViewTemplate } from '@ni/fast-element'; -import { - type FoundationElementTemplate -} from '@ni/fast-foundation'; +import type { FoundationElementTemplate } from '@ni/fast-foundation'; import type { ChatMessageOutbound } from '.'; export const template: FoundationElementTemplate< diff --git a/packages/spright-components/src/chat/message/system/template.ts b/packages/spright-components/src/chat/message/system/template.ts index 5f9fe81c9f..e62f2656cd 100644 --- a/packages/spright-components/src/chat/message/system/template.ts +++ b/packages/spright-components/src/chat/message/system/template.ts @@ -1,7 +1,5 @@ import { html, ViewTemplate } from '@ni/fast-element'; -import { - type FoundationElementTemplate -} from '@ni/fast-foundation'; +import type { FoundationElementTemplate } from '@ni/fast-foundation'; import type { ChatMessageSystem } from '.'; export const template: FoundationElementTemplate<