Multiple Handlers

[mybigman]

Nice little routes decorator you have there. I've just started playing around with python again and using tornado web framework.

Everything works, however just not sure if this the best approach using your route decorator with multiple handlers?

Thanks

# handlers/__init__.py
from handlers.base import route
from handlers import base, home, summary

routes = route.get_routes()

# handlers/base.py
from vendor.router import route
from tornado.web import RequestHandler

class BaseHandler(RequestHandler):
    pass

# handlers/home.py
from handlers.base import route, BaseHandler

@route('/', name='home')
class HomeHandler(BaseHandler):
    def get(self):
        self.write({'home': {}})

# handlers/summary.py
from handlers.base import route, BaseHandler

@route('/summary', name='summary',
class SummaryHandler(BaseHandler):
    def get(self):
        self.write({'summary': {})

# app.py
from handlers import route

print(route.get_routes())

[nod]

I have no issues using the decorator with multiple handlers. Are you seeing a problem with it?

I actually have some minor updates to it to push for some python3 related tweaks and a new feature to allow you to set prefixes at runtime for routes. This is helpful when deploying an app that needs to get nested off the root in some way. It's a little clunky but works pretty well overall.

[mybigman]

@nod As I mentioned I have no issues at all and it works great. My question was about how I went about it... would it be considered a "pythonic" way of handling this or would there be a better approach?

I come from a long PHP background and using Laravel Framework where a lot of the setup is dictated to you.

Oh and BTW I made a small tweak to you code which you might like to add?

def __init__(self, uri, name=None, kwargs={}):
        self._uri = uri
        self.name = name
        self.kwargs = kwargs

 def __call__(self, _handler):
        """gets called when we class decorate"""
        name = self.name or _handler.__name__
        self._routes.append(tornado.web.url(self._uri, _handler, self.kwargs, name=name))
        return _handler

This allows you to pass keyword arguments.

[nod]

Apologies, I should have read closer. What you're doing seems right.

I like your keyword args idea. Mind sending a pull request with a test for it?

I'll be (hopefully as time permits) pushing some minor tweaks and updating in pypi this week.

[mybigman]

@nod sent PR... not up to speed on python tests but hopefully its ok.