This repository was archived by the owner on Sep 2, 2021. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 0
Thanks!Β #1
Copy link
Copy link
Open
Description
Overall
- π Thank you, this is a great submission.
- The point of this homework was to explore some basic Android components with a RESTful API. You learned about ListView, custom ArrayAdapter and basic networking.
Good stuffs
- My first comment is your source code is very clean π»
- I see that you can implement clearly project structure.
- It good to see you define that one below, but I think it's better if you try to implement
enum.
private final int HIGH_RATING_MOVIE = 1;
private final int NORMAL_RATING_MOVIE = 0;
- Great job using
ButterKnifeto bind view. - Nice job implementing
Retrofitfor basic networking stuff. Hope you understand deeply this library. - Nice work using
ArrayAdapteras customize withView Holderpattern. πswitch (type)to figure out 2 differents listview items. - Great to see you using
Glidefor loading image asychonously. - Great job seperating into detail models, with
gsonto parse JSON stuff.
Suggestions
- Completely, you've gone so far on the first assignment. Keep moving!!!
- I wish that you write down some challenges after each assignment, and how can you pass over all of them π₯ β¨
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels