Skip to content

refactor: remove pqina, use native Canvas #3353

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
olgahaha merged 3 commits into from
Feb 5, 2026
Merged

refactor: remove pqina, use native Canvas #3353

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
2c6046b
refactor: remove pqina, use native Canvas
olgahaha Feb 4, 2026
4c49eac
chore: fix CI build and update appsflyer
olgahaha Feb 5, 2026
274954a
fix: resolve eslint magic numbers error in grayscale
olgahaha Feb 5, 2026
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 1 addition & 3 deletions .github/workflows/build-apks.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -34,7 +34,7 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: '20.11.1'
node-version: '22'

- name: Check if version has been updated
id: version_check
Expand All @@ -60,11 +60,9 @@ jobs:
NUMBERS_BUBBLE_DB_URL: ${{ secrets[matrix.bubble_db_url] }}
BUBBLE_API_URL: ${{ secrets.BUBBLE_API_URL}} # FIXME: remove BUBBLE_API_URL, not used in capture app.
APPS_FLYER_DEV_KEY: '' # Empty string prevents apps flyer SDK initialization for non-public flavors.
NUMBERS_PQINA_NPM_KEY: ${{ secrets.NUMBERS_PQINA_NPM_KEY }} # same for public, non-public flavors.
GOOGLE_IOS_CLIENT_ID: ${{ secrets.GOOGLE_IOS_CLIENT_ID }}
GOOGLE_WEB_CLIENT_ID: ${{ secrets.GOOGLE_WEB_CLIENT_ID }}
run: |
npm run preconfig.npmrc
npm install -g @ionic/cli
npm install --legacy-peer-deps
npm run build
Expand Down
16 changes: 2 additions & 14 deletions .github/workflows/build.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,16 +15,11 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.11.1'
node-version: '22'

- name: Install Ionic CLI
run: npm install -g @ionic/cli

- name: Generate .npmrc for pintura package
env:
NUMBERS_PQINA_NPM_KEY: ${{ secrets.NUMBERS_PQINA_NPM_KEY }}
run: npm run preconfig.npmrc

- name: Install dependencies
run: npm install --legacy-peer-deps

Expand All @@ -36,7 +31,6 @@ jobs:
NUMBERS_BUBBLE_IFRAME_URL: ${{ secrets.NUMBERS_BUBBLE_IFRAME_URL }}
BUBBLE_API_URL: ${{ secrets.BUBBLE_API_URL }}
APPS_FLYER_DEV_KEY: ${{ secrets.APPS_FLYER_DEV_KEY }}
NUMBERS_PQINA_NPM_KEY: ${{ secrets.NUMBERS_PQINA_NPM_KEY }}
GOOGLE_IOS_CLIENT_ID: ${{ secrets.GOOGLE_IOS_CLIENT_ID }}
GOOGLE_WEB_CLIENT_ID: ${{ secrets.GOOGLE_WEB_CLIENT_ID }}
run: npm run build
Expand Down Expand Up @@ -69,7 +63,7 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.11.1'
node-version: '22'

- name: Setup Python
uses: actions/setup-python@v5
Expand All @@ -79,11 +73,6 @@ jobs:
- name: Install Ionic CLI
run: npm install -g @ionic/cli

- name: Generate .npmrc for pintura package
env:
NUMBERS_PQINA_NPM_KEY: ${{ secrets.NUMBERS_PQINA_NPM_KEY }}
run: npm run preconfig.npmrc

- name: Install dependencies
run: npm install --legacy-peer-deps

Expand All @@ -95,7 +84,6 @@ jobs:
NUMBERS_BUBBLE_IFRAME_URL: ${{ secrets.NUMBERS_BUBBLE_IFRAME_URL }}
BUBBLE_API_URL: ${{ secrets.BUBBLE_API_URL }}
APPS_FLYER_DEV_KEY: ${{ secrets.APPS_FLYER_DEV_KEY }}
NUMBERS_PQINA_NPM_KEY: ${{ secrets.NUMBERS_PQINA_NPM_KEY }}
GOOGLE_IOS_CLIENT_ID: ${{ secrets.GOOGLE_IOS_CLIENT_ID }}
GOOGLE_WEB_CLIENT_ID: ${{ secrets.GOOGLE_WEB_CLIENT_ID }}
run: npm run build
Expand Down
8 changes: 2 additions & 6 deletions .github/workflows/firebase-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -29,7 +29,7 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: '20.11.1'
node-version: '22'

- name: Setup firebase
run: |
Expand All @@ -43,11 +43,9 @@ jobs:
NUMBERS_BUBBLE_IFRAME_URL: ${{ secrets.NUMBERS_BUBBLE_IFRAME_URL_QA_RELEASE }}
BUBBLE_API_URL: ${{ secrets.BUBBLE_API_URL }}
APPS_FLYER_DEV_KEY: ${{ secrets.APPS_FLYER_DEV_KEY }}
NUMBERS_PQINA_NPM_KEY: ${{ secrets.NUMBERS_PQINA_NPM_KEY }}
GOOGLE_IOS_CLIENT_ID: ${{ secrets.GOOGLE_IOS_CLIENT_ID }}
GOOGLE_WEB_CLIENT_ID: ${{ secrets.GOOGLE_WEB_CLIENT_ID }}
run: |
npm run preconfig.npmrc
npm install -g @ionic/cli
npm install --legacy-peer-deps
npm run build
Expand Down Expand Up @@ -98,7 +96,7 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: '20.11.1'
node-version: '22'

- name: Setup Python
uses: actions/setup-python@v5
Expand All @@ -117,11 +115,9 @@ jobs:
NUMBERS_BUBBLE_IFRAME_URL: ${{ secrets.NUMBERS_BUBBLE_IFRAME_URL_QA_RELEASE }}
BUBBLE_API_URL: ${{ secrets.BUBBLE_API_URL }}
APPS_FLYER_DEV_KEY: ${{ secrets.APPS_FLYER_DEV_KEY }}
NUMBERS_PQINA_NPM_KEY: ${{ secrets.NUMBERS_PQINA_NPM_KEY }}
GOOGLE_IOS_CLIENT_ID: ${{ secrets.GOOGLE_IOS_CLIENT_ID }}
GOOGLE_WEB_CLIENT_ID: ${{ secrets.GOOGLE_WEB_CLIENT_ID }}
run: |
npm run preconfig.npmrc
npm install -g @ionic/cli
npm install --legacy-peer-deps
npm run build
Expand Down
12 changes: 3 additions & 9 deletions .github/workflows/pre-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -15,7 +15,7 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: '20.11.1'
node-version: '22'

- name: Get release version
id: version_check
Expand All @@ -29,11 +29,9 @@ jobs:
NUMBERS_BUBBLE_IFRAME_URL: ${{ secrets.NUMBERS_BUBBLE_IFRAME_URL_QA_RELEASE }}
BUBBLE_API_URL: ${{ secrets.BUBBLE_API_URL }}
APPS_FLYER_DEV_KEY: ${{ secrets.APPS_FLYER_DEV_KEY }}
NUMBERS_PQINA_NPM_KEY: ${{ secrets.NUMBERS_PQINA_NPM_KEY }}
GOOGLE_IOS_CLIENT_ID: ${{ secrets.GOOGLE_IOS_CLIENT_ID }}
GOOGLE_WEB_CLIENT_ID: ${{ secrets.GOOGLE_WEB_CLIENT_ID }}
run: |
npm run preconfig.npmrc
npm install -g @ionic/cli
npm install --legacy-peer-deps
npm run build
Expand Down Expand Up @@ -94,7 +92,7 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: '20.11.1'
node-version: '22'

- name: Get release version
id: version_check
Expand All @@ -108,11 +106,9 @@ jobs:
NUMBERS_BUBBLE_IFRAME_URL: ${{ secrets.NUMBERS_BUBBLE_IFRAME_URL }}
BUBBLE_API_URL: ${{ secrets.BUBBLE_API_URL }}
APPS_FLYER_DEV_KEY: ${{ secrets.APPS_FLYER_DEV_KEY }}
NUMBERS_PQINA_NPM_KEY: ${{ secrets.NUMBERS_PQINA_NPM_KEY }}
GOOGLE_IOS_CLIENT_ID: ${{ secrets.GOOGLE_IOS_CLIENT_ID }}
GOOGLE_WEB_CLIENT_ID: ${{ secrets.GOOGLE_WEB_CLIENT_ID }}
run: |
npm run preconfig.npmrc
npm install -g @ionic/cli
npm install --legacy-peer-deps
npm run build
Expand Down Expand Up @@ -183,7 +179,7 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: '20.11.1'
node-version: '22'

- name: Setup Python
uses: actions/setup-python@v5
Expand All @@ -202,11 +198,9 @@ jobs:
NUMBERS_BUBBLE_IFRAME_URL: ${{ secrets.NUMBERS_BUBBLE_IFRAME_URL }}
BUBBLE_API_URL: ${{ secrets.BUBBLE_API_URL }}
APPS_FLYER_DEV_KEY: ${{ secrets.APPS_FLYER_DEV_KEY }}
NUMBERS_PQINA_NPM_KEY: ${{ secrets.NUMBERS_PQINA_NPM_KEY }}
GOOGLE_IOS_CLIENT_ID: ${{ secrets.GOOGLE_IOS_CLIENT_ID }}
GOOGLE_WEB_CLIENT_ID: ${{ secrets.GOOGLE_WEB_CLIENT_ID }}
run: |
npm run preconfig.npmrc
npm install -g @ionic/cli
npm install --legacy-peer-deps
npm run build
Expand Down
14 changes: 2 additions & 12 deletions .github/workflows/test.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,16 +13,11 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.11.1'
node-version: '22'

- name: Install Ionic CLI
run: npm install -g @ionic/cli

- name: Generate .npmrc for pintura package
env:
NUMBERS_PQINA_NPM_KEY: ${{ secrets.NUMBERS_PQINA_NPM_KEY }}
run: npm run preconfig.npmrc

- name: Install dependencies
run: npm install --legacy-peer-deps

Expand All @@ -39,16 +34,11 @@ jobs:
- name: Use Node.js
uses: actions/setup-node@v4
with:
node-version: '20.11.1'
node-version: '22'

- name: Install Ionic CLI
run: npm install -g @ionic/cli

- name: Generate .npmrc for pintura package
env:
NUMBERS_PQINA_NPM_KEY: ${{ secrets.NUMBERS_PQINA_NPM_KEY }}
run: npm run preconfig.npmrc

- name: Install dependencies
run: npm install --legacy-peer-deps

Expand Down
2 changes: 1 addition & 1 deletion .github/workflows/uiux-release.yml
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -13,7 +13,7 @@ jobs:

- uses: actions/setup-node@v4
with:
node-version: '20.11.1'
node-version: '22'

- name: Build Ionic
env:
Expand Down
4 changes: 3 additions & 1 deletion .gitignore
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -41,4 +41,6 @@ resources/android/splash
resources/ios/icon
resources/ios/splash
resources/windows/icon
resources/windows/splash
resources/windows/splash

build/
19 changes: 12 additions & 7 deletions .stylelintrc.json
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -1,6 +1,5 @@
{
"extends": "stylelint-config-standard",
"plugins": ["stylelint-scss"],
"extends": "stylelint-config-standard-scss",
"rules": {
"selector-type-no-unknown": [
true,
Expand All @@ -9,16 +8,22 @@
}
],
"no-empty-source": null,
"at-rule-no-unknown": null,
"scss/at-rule-no-unknown": true,
"color-function-notation": "modern",
"color-named": "always-where-possible",
"declaration-no-important": true,
"keyframe-declaration-no-important": true,
"value-no-vendor-prefix": true,
"shorthand-property-no-redundant-values": true,
"selector-no-vendor-prefix": true,
"at-rule-no-vendor-prefix": true,
"alpha-value-notation": "number"
"alpha-value-notation": "number",
"color-function-notation": null,
"scss/comment-no-empty": null,
"scss/double-slash-comment-empty-line-before": null,
"scss/at-mixin-argumentless-call-parentheses": null,
"scss/dollar-variable-empty-line-before": null,
"declaration-block-no-redundant-longhand-properties": null,
"selector-class-pattern": null,
"property-no-vendor-prefix": null,
"media-feature-range-notation": null,
"color-function-alias-notation": null
}
}
3 changes: 0 additions & 3 deletions angular.json
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -39,9 +39,6 @@
},
{
"input": "node_modules/material-design-icons-iconfont/dist/material-design-icons.css"
},
{
"input": "node_modules/@pqina/pintura/pintura.css"
}
],
"scripts": [],
Expand Down
18 changes: 9 additions & 9 deletions ios/App/Podfile.lock
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -10,12 +10,12 @@ PODS:
- GoogleUtilities/Environment (~> 8.0)
- GoogleUtilities/UserDefaults (~> 8.0)
- PromisesObjC (~> 2.4)
- AppsflyerCapacitorPlugin (6.15.2):
- AppsFlyerFramework (= 6.15.3)
- AppsflyerCapacitorPlugin (6.17.8):
- AppsFlyerFramework (= 6.17.8)
- Capacitor
- AppsFlyerFramework (6.15.3):
- AppsFlyerFramework/Main (= 6.15.3)
- AppsFlyerFramework/Main (6.15.3)
- AppsFlyerFramework (6.17.8):
- AppsFlyerFramework/Main (= 6.17.8)
- AppsFlyerFramework/Main (6.17.8)
- Capacitor (7.4.3):
- CapacitorCordova
- CapacitorApp (7.0.0):
Expand Down Expand Up @@ -61,7 +61,7 @@ PODS:
- FBSDKCoreKit (= 17.4.0)
- FBSDKLoginKit (= 17.4.0)
- GoogleSignIn (~> 8.0.0)
- CordovaPlugins (7.4.3):
- CordovaPlugins (7.4.5):
- CapacitorCordova
- FalconetaCapacitorWifiConnect (7.0.0):
- Capacitor
Expand Down Expand Up @@ -259,8 +259,8 @@ SPEC CHECKSUMS:
Alamofire: 7193b3b92c74a07f85569e1a6c4f4237291e7496
AppAuth: d4f13a8fe0baf391b2108511793e4b479691fb73
AppCheckCore: cc8fd0a3a230ddd401f326489c99990b013f0c4f
AppsflyerCapacitorPlugin: 3510699914dd2f25ca7ed47c9bfe833f402be053
AppsFlyerFramework: ad7ff0d22aa36c7f8cc4f71a5424e19b89ccb8ae
AppsflyerCapacitorPlugin: bb320adfb3fcde436a53e6e9132a03e2fbd60d91
AppsFlyerFramework: 63577b60d6b9fcdab60135289979e7d1c9ec79b9
Capacitor: 28d6c01026a9a3f7156529498ec1f389a2a28dbc
CapacitorApp: 9cb31064a6c6bb2b1438583733a7bf45557fc1da
CapacitorBlobWriter: d709e5d22ab9989afd730eb4773873d1ded5fd08
Expand All @@ -281,7 +281,7 @@ SPEC CHECKSUMS:
CapacitorShare: d94c53d7656f1ce8f6712ae8d19ab0c18a69259f
CapacitorSplashScreen: 7e7a0a1113833032f196b3af6fa437baccacf5bc
CapgoCapacitorSocialLogin: 0fcf5cf6d447ec4992c3e9e4fcae70c19d12919b
CordovaPlugins: 32fa8833e41de121e3f185b0c033815b1be91a13
CordovaPlugins: 4e4b10b11bd2b55de8912c6d5459f0904c0c2864
FalconetaCapacitorWifiConnect: c8c26550fe3fca67cf7aac174b09f0805aabf107
FBAEMKit: 58cb5f302cdd715a56d4c1d0dfdd2e423ac1421a
FBSDKCoreKit: 94d7461d0cecf441b1ba7c41acfff41daa8ccd41
Expand Down
Loading
Loading