weird ^M at the end of line on Windows?

[nielpattin]

I'm using Windows, and EOL is LF (yes, I am not a fan of CRLF)

But whatever I replace text, it comes up with ^M at the end of the line.

Default setup

return {
    "nvim-pack/nvim-spectre",
    dependencies = {
        "nvim-lua/plenary.nvim",
   },
   keys = {
    {
      "<leader>S",
      function()
        require("spectre").toggle()
      end,
      desc = "Spectre",
    },
  },
  opts = {},
}

My config

[EpsilonKu]

definitely sed issue. Seems like it converts files from LF to CRLF after replace. I dunno how to solve it. Seems like you need to run by hand to remove ^M. Will be good if @windwp can help.
I will try to reproduce issue.

[GitMurf]

I am having same issue and the biggest problem is that it then messes up my undo history as it looks like the entire file was replaced/changed because every line adds the ^M carriage return. Anyone make any progress on this or have any ideas?

[GitMurf]

It seems we need to be able to run sed with the binary flag maybe? Is there a way to pass configuration / flags to sed from spectre?

https://www.gnu.org/software/sed/manual/sed.html

[EpsilonKu]

Yeah, sure.

replace_engine={
      ['sed']={
          cmd = "sed",
          args = {'--binary'},

      },
  },

[GitMurf]

yeah unfortunately that doesn't fix it :( it is some weird thing with sed and windows where it is saving the file in windows native format of crlf even when the file itself starts as lf unix style.

[GitMurf]

@EpsilonKu is sd option supposed to be officially supported now to use? i see mention in the readme but not much more and looks like maybe a recent PR? I am getting an error on Windows:

E5108: Error executing lua ...kstart-data/lazy/nvim-spectre/lua/spectre/replace/sd.lua:19: attempt to index local 'file' (a nil value)

I would not be surprised if it is a windows path issue where the file arg is not being properly escaped or something. sed works fine (other than the ^M \r line feed issue).

[EpsilonKu]

Yeah, sd was added recently. Hope @Zananok can help. Sadly I don't have ready windows to reproduce issue.

[Zananok]

Problem is the line above, which opens the file:
local file = io.open(value.filename, "r")
So, it means its not finding the file. I can do a simple PR later to improve readability of the error, but if you add a print(value.filename) just above, you will probably see a non proper formulated path due to windows or something.

As for ^M, its windows tools that causes this. You can run "dos2unix filename" on the file and should fix it. Additionally, but I haven't tested, after you save the file with ^M, run on the nvim: :!dos2unix. But this tool is for linux, so I am not sure if you have access to it.

I run my nvim on wsl, to avoid these troublesome issues, but even so, mixing wsl with windows gave me a fair share of issues.

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.

[GitMurf]

Bot is marking as stale. Bumping to see if this is something someone is willing considering to fix down the road. Thanks!

[stale]

This issue has been automatically marked as stale because it has not had recent activity. It will be closed if no further activity occurs. Thank you for your contributions.