Skip to content

[Crash] Unchecked msg.servicesMeta.startTime access in requestConfig #51

@coderabbitai

Description

@coderabbitai

Summary

Game server crashes when services send requestConfig response without servicesMeta.

Affected Code

server-game/start-game.js:230

if ((msg.servicesMeta.startTime > ss.config.servicesMeta.startTime) && ss.isPerpetual) {
  // CRASH if msg.servicesMeta is undefined

Vulnerability

If services server sends incomplete config or a malicious client spoofs the services response.

Impact

  • Game server crash
  • Denial of service

Proof of Concept

Send {"cmd":"requestConfig"} without servicesMeta field.

Recommended Fix

if ((msg.servicesMeta?.startTime > ss.config.servicesMeta?.startTime) && ss.isPerpetual) {

References

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions