Skip to content

[Crash] Unchecked this.userData.ownedItemIds.includes in item validation #54

@coderabbitai

Description

@coderabbitai

Summary

Game server crashes when this.userData.ownedItemIds is undefined during item check.

Affected Code

server-game/src/client.js:468

&& this.userData.ownedItemIds.includes(item.id) // CRASH if ownedItemIds is undefined

Vulnerability

If userData load fails or is incomplete.

Impact

  • Game server crash during item validation
  • Denial of service

Recommended Fix

&& this.userData?.ownedItemIds?.includes(item.id)

References

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions