Skip to content

Commit 14bd341

Browse files
committed
remove firebase-config and analytics
1 parent 999c1fd commit 14bd341

File tree

3 files changed

+13
-44
lines changed

3 files changed

+13
-44
lines changed

app/build.gradle

Lines changed: 0 additions & 2 deletions
Original file line numberDiff line numberDiff line change
@@ -139,8 +139,6 @@ dependencies {
139139
implementation 'com.google.firebase:firebase-storage'
140140
implementation 'com.google.firebase:firebase-auth'
141141
implementation 'com.google.firebase:firebase-crashlytics-ndk'
142-
implementation 'com.google.firebase:firebase-analytics'
143-
implementation 'com.google.firebase:firebase-config'
144142

145143
implementation 'com.google.android.gms:play-services-ads:24.3.0'
146144
implementation 'com.google.android.play:review:2.0.2'

app/src/main/java/at/tomtasche/reader/nonfree/AnalyticsManager.java

Lines changed: 6 additions & 15 deletions
Original file line numberDiff line numberDiff line change
@@ -5,22 +5,12 @@
55
import android.os.Bundle;
66
import android.util.Log;
77

8-
import com.google.firebase.analytics.FirebaseAnalytics;
9-
108
public class AnalyticsManager {
119

1210
private boolean enabled;
1311

14-
private FirebaseAnalytics analytics;
15-
1612
public void initialize(Context context) {
17-
if (!enabled) {
18-
FirebaseAnalytics.getInstance(context).setAnalyticsCollectionEnabled(false);
19-
20-
return;
21-
}
22-
23-
analytics = FirebaseAnalytics.getInstance(context);
13+
return;
2414
}
2515

2616
public void setEnabled(boolean enabled) {
@@ -44,7 +34,7 @@ public void report(String event, String key1, Object value1, String key2, Object
4434
bundle.putString(key2, String.valueOf(value2));
4535
}
4636

47-
analytics.logEvent(event, bundle);
37+
Log.i("smn", event);
4838
}
4939

5040
public void report(String event, String key, Object value) {
@@ -57,8 +47,9 @@ public void setCurrentScreen(Activity activity, String name) {
5747
}
5848

5949
Bundle bundle = new Bundle();
60-
bundle.putString(FirebaseAnalytics.Param.SCREEN_NAME, name);
61-
bundle.putString(FirebaseAnalytics.Param.SCREEN_CLASS, activity.getClass().getSimpleName());
62-
analytics.logEvent(FirebaseAnalytics.Event.SCREEN_VIEW, bundle);
50+
bundle.putString("screen_name", name);
51+
bundle.putString("screen_class", activity.getClass().getSimpleName());
52+
53+
Log.i("smn", name);
6354
}
6455
}

app/src/main/java/at/tomtasche/reader/nonfree/ConfigManager.java

Lines changed: 7 additions & 27 deletions
Original file line numberDiff line numberDiff line change
@@ -1,28 +1,14 @@
11
package at.tomtasche.reader.nonfree;
22

3-
import android.net.Uri;
4-
5-
import com.google.android.gms.tasks.OnCompleteListener;
6-
import com.google.android.gms.tasks.Task;
7-
import com.google.firebase.remoteconfig.FirebaseRemoteConfig;
8-
93
import java.util.LinkedList;
104
import java.util.List;
11-
import java.util.concurrent.TimeoutException;
12-
13-
import androidx.annotation.NonNull;
14-
15-
import at.tomtasche.reader.R;
16-
import at.tomtasche.reader.ui.activity.MainActivity;
175

186
public class ConfigManager {
197

208
private boolean enabled;
219

2210
private boolean loaded;
2311

24-
private FirebaseRemoteConfig remoteConfig;
25-
2612
private final List<Runnable> callbacks;
2713

2814
public ConfigManager() {
@@ -34,19 +20,13 @@ public void initialize() {
3420
return;
3521
}
3622

37-
remoteConfig = FirebaseRemoteConfig.getInstance();
38-
remoteConfig.fetchAndActivate().addOnCompleteListener(new OnCompleteListener<Boolean>() {
39-
@Override
40-
public void onComplete(@NonNull Task<Boolean> task) {
41-
synchronized (callbacks) {
42-
loaded = true;
23+
synchronized (callbacks) {
24+
loaded = true;
4325

44-
for (Runnable callback : callbacks) {
45-
callback.run();
46-
}
47-
}
26+
for (Runnable callback : callbacks) {
27+
callback.run();
4828
}
49-
});
29+
}
5030
}
5131

5232
public boolean isLoaded() {
@@ -80,7 +60,7 @@ public void run() {
8060
}
8161
}
8262

83-
boolean value = remoteConfig.getBoolean(key);
63+
boolean value = getBooleanConfig(key);
8464
configListener.onConfig(key, value);
8565
}
8666

@@ -89,7 +69,7 @@ public boolean getBooleanConfig(String key) {
8969
return false;
9070
}
9171

92-
return remoteConfig.getBoolean(key);
72+
return false;
9373
}
9474

9575
public interface ConfigListener<T> {

0 commit comments

Comments
 (0)