-
Notifications
You must be signed in to change notification settings - Fork 4
feat: rename and materialize django models #76
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
|
Thanks for the pull request, @Henrrypg! This repository is currently maintained by Once you've gone through the following steps feel free to tag them in a comment and let them know that your changes are ready for engineering review. 🔘 Get product approvalIf you haven't already, check this list to see if your contribution needs to go through the product review process.
🔘 Provide contextTo help your reviewers and other members of the community understand the purpose and larger context of your changes, feel free to add as much of the following information to the PR description as you can:
🔘 Get a green buildIf one or more checks are failing, continue working on your changes until this is no longer the case and your build turns green. DetailsWhere can I find more information?If you'd like to get more details on all aspects of the review process for open source pull requests (OSPRs), check out the following resources: When can I expect my changes to be merged?Our goal is to get community contributions seen and reviewed as efficiently as possible. However, the amount of time that it takes to review and merge a PR can vary significantly based on factors such as:
💡 As a result it may take up to several weeks or months to complete a review and merge your PR. |
d504efb to
119310f
Compare
Codecov Report✅ All modified and coverable lines are covered by tests. Additional details and impacted files@@ Coverage Diff @@
## main #76 +/- ##
==========================================
+ Coverage 88.64% 89.37% +0.72%
==========================================
Files 44 45 +1
Lines 3197 3773 +576
Branches 213 256 +43
==========================================
+ Hits 2834 3372 +538
- Misses 288 313 +25
- Partials 75 88 +13
Flags with carried forward coverage won't be shown. Click here to find out more. ☔ View full report in Codecov by Sentry. 🚀 New features to boost your workflow:
|
feat: add support for comments with json5 feat: moving profiles
a576e22 to
44e4215
Compare
|
@felipemontoya |
2b1b248 to
024f950
Compare
| action: 'clear_session', | ||
| payload: { | ||
| requestId: `ai-request-${Date.now()}`, | ||
| courseId: preparedContext.courseId || null, |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Are we getting the course_id in a different manner? If we can get it from the backend directly that would be much better, but we still need it as I wrote in the performance of the get_config method.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
we was taking it from both payload and query params before, and this one wasn't use, i removed it from payload to have consistency in both requests (profile/(GET) and workflows/(POST))
bb1f03d to
9dfb603
Compare
felipemontoya
left a comment
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks @Henrrypg. While doing my second review I found two errors which I corrected. I'll push those to your branch
This pull request introduces a new AI Workflow Profile and Scope system, replacing the previous configuration model to enable more flexible and maintainable management of AI workflow templates and their application contexts. It adds new models, admin interfaces, API endpoints, and serializer logic to support this change, along with associated database migrations.
Key changes include:
Models and Database
AIWorkflowProfilefor reusable workflow template definitions, andAIWorkflowScopefor mapping profiles to course/location/service contexts, with associated migrations. UpdatedAIWorkflowSessionto reference these new models and enforce uniqueness.Admin Interface
AIWorkflowProfile, featuring a custom form with JSON5 patch validation, template preview, merged configuration preview, and validation status display. Also added an admin interface forAIWorkflowScope.API and Serialization
AIWorkflowProfileViewandAIWorkflowProfileSerializerto expose only the relevant UI components to the frontend.Workflow Execution Logic
AIWorkflowScope.get_configfor context-aware profile selection and execution, simplifying request handling and removing legacy configuration logic.These changes collectively establish a more modular, extensible, and user-friendly system for managing AI workflow templates and their application across different Open edX contexts.