Skip to content

Commit a0bf3f4

Browse files
committed
fix(ci): assert on invalid version_code during release
1 parent 8349539 commit a0bf3f4

File tree

3 files changed

+15
-1
lines changed

3 files changed

+15
-1
lines changed

.github/workflows/release.yaml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -68,6 +68,13 @@ jobs:
6868
env:
6969
KEYSTORE_BASE64: ${{ secrets.KEYSTORE_BASE64 }}
7070

71+
- name: Assert that version code is valid
72+
run: |
73+
if ! [[ "${VERSION_CODE}" =~ ^[0-9]+$ ]]; then
74+
echo "VERSION_CODE is not a valid integer: ${VERSION_CODE}"
75+
exit 1
76+
fi
77+
7178
- name: Build release APKs
7279
uses: ./.github/actions/gradle-task
7380
with:

.pre-commit-config.yaml

Lines changed: 7 additions & 0 deletions
Original file line numberDiff line numberDiff line change
@@ -55,3 +55,10 @@ repos:
5555
types_or:
5656
- kotlin
5757
language: system
58+
- id: fastlane
59+
name: Fastlane lint
60+
description: Lints fastlane configuration
61+
entry: bundle exec fastlane list
62+
pass_filenames: false
63+
language: system
64+
files: ^fastlane/Fastfile$

project/app/build.gradle.kts

Lines changed: 1 addition & 1 deletion
Original file line numberDiff line numberDiff line change
@@ -18,7 +18,7 @@ val googleMapsAPIKey =
1818

1919
val gmsImplementation: Configuration by configurations.creating
2020

21-
val packageVersionCode: Int = System.getenv("VERSION_CODE")?.toInt() ?: 420505000
21+
val packageVersionCode: Int = System.getenv("VERSION_CODE")?.toInt() ?: 1
2222
val manuallySetVersion: Boolean = System.getenv("VERSION_CODE") != null
2323
val enablePlayPublishing: Boolean = !System.getenv("ANDROID_PUBLISHER_CREDENTIALS").isNullOrBlank()
2424

0 commit comments

Comments
 (0)