webservice: Enable not being used/checked

[BrewNinja]

I tried setting this up with the URI being set as Enabled: False and it errors out. I think I see the issue, the enabled value isn't being checked/used at all in this block. It is checked/set in Get-ChWebServiceEnabled, but that is only used in the logging. Also, the other 2 values in webService don't look at enabled at all anywhere (and UseAPIConfig isnt used at all in any of it, maybe thats a "someday" feature, not sure).

$GetConfigFromAPI = Get-ChWebServiceUseConfigFromApi
if ($GetConfigFromAPI) {
    $WebApiUrl = Get-ChWebServiceUri
    $WebApiKey = Get-ChWebServiceApiKey
    try {
        $configText = Get-ConfigFromWebservice -URI $WebApiUrl -ApiKey $WebApiKey -ErrorAction Stop
        $json = $configText
    }
    catch {
        write-Error $_
        Exit 1
    }
    try {
        $configJsonString = ConvertTo-Json $configText
        Out-File -FilePath $ConfigFilePath -InputObject $configJsonString -ErrorAction Stop
    }
    catch{
        Write-Warning "Failed to write updated Configuration locally to file: $ConfigFilePath"
    }
}

[paulwetter]

What is the error you are getting? if Enable is set to false, then that entire if statement you highlighted "should" be skipped. If it isn't being skipped, then something isn't working correctly:

    "webService":  [
                       {
                           "name":  "URI",
                           "value":  "https://server.domain.com:7107",
                           "enable":  "true"
                       },
                       {
                           "name":  "ApiKey",
                           "value":  "Thisisthekey12345678",
                           "enable":  "true"
                       },
                       {
                           "name":  "UseApiConfig",
                           "value":  "",
                           "enable":  "false"    <<<If this is false
                       }

The enable for the other 2 are not used as you say. This was an attempt to use a standard object type for all name/value pairs with a bool enable that could be used sometimes. I should probably change that an make it nullable. Then, we should be able to exclude where its not being used, like for URI and ApiKey.

[BrewNinja]

While I understand what its supposed to do, it still tries to use the API even if all values are false.

[BrewNinja]

Found the issue:

PS C:\WINDOWS\system32> $GetConfigFromAPI
false
PS C:\WINDOWS\system32> $GetConfigFromAPI.GetType().FullName
System.String

Which causes if ($GetConfigFromAPI) { to continue because it has a string value.

[paulwetter]

Hah! Yah, that would do it. Will have to revisit some of these and force/change them to a bool. Part of the Alpha tag. ;) Admittedly didn't fully test all of these. For now could work around with a [bool]::Parse($GetConfigFromAPI). I should really probably change this in the json models to bools. Why i didn't do that to begin with... We may never know. lol

[BrewNinja]

No problem! Figured I would post the issue on here like you asked me to when I found it (I emailed you a couple weeks ago asking what was still Alpha).