From 1997145436b2511f2cfbe761fc56c53cfe8dcf26 Mon Sep 17 00:00:00 2001 From: Souvik Ghosh Date: Fri, 29 Nov 2019 15:43:12 +0530 Subject: [PATCH 1/2] put retriever.setDataSource(...) inside try-catch --- .../java/me/hauvo/thumbnail/RNThumbnailModule.java | 12 +++++++----- 1 file changed, 7 insertions(+), 5 deletions(-) diff --git a/android/src/main/java/me/hauvo/thumbnail/RNThumbnailModule.java b/android/src/main/java/me/hauvo/thumbnail/RNThumbnailModule.java index 33264a7..558a547 100644 --- a/android/src/main/java/me/hauvo/thumbnail/RNThumbnailModule.java +++ b/android/src/main/java/me/hauvo/thumbnail/RNThumbnailModule.java @@ -41,12 +41,14 @@ public String getName() { public void get(String filePath, Promise promise) { filePath = filePath.replace("file://",""); MediaMetadataRetriever retriever = new MediaMetadataRetriever(); - retriever.setDataSource(filePath); - Bitmap image = retriever.getFrameAtTime(1000000, MediaMetadataRetriever.OPTION_CLOSEST_SYNC); - - String fullPath = Environment.getExternalStorageDirectory().getAbsolutePath() + "/thumb"; try { + retriever.setDataSource(filePath); + Bitmap image = retriever.getFrameAtTime(1000000, MediaMetadataRetriever.OPTION_CLOSEST_SYNC); + retriever.release(); + + String fullPath = Environment.getExternalStorageDirectory().getAbsolutePath() + "/thumb"; + File dir = new File(fullPath); if (!dir.exists()) { dir.mkdirs(); @@ -77,6 +79,6 @@ public void get(String filePath, Promise promise) { } catch (Exception e) { Log.e("E_RNThumnail_ERROR", e.getMessage()); promise.reject("E_RNThumnail_ERROR", e); - } + } } } From 337d10b2df16a3ae2239b348104f146f20bf5cd4 Mon Sep 17 00:00:00 2001 From: Souvik Ghosh Date: Fri, 29 Nov 2019 15:54:07 +0530 Subject: [PATCH 2/2] Update RNThumbnailModule.java remove whitespace --- android/src/main/java/me/hauvo/thumbnail/RNThumbnailModule.java | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/android/src/main/java/me/hauvo/thumbnail/RNThumbnailModule.java b/android/src/main/java/me/hauvo/thumbnail/RNThumbnailModule.java index 558a547..01aa8fb 100644 --- a/android/src/main/java/me/hauvo/thumbnail/RNThumbnailModule.java +++ b/android/src/main/java/me/hauvo/thumbnail/RNThumbnailModule.java @@ -79,6 +79,6 @@ public void get(String filePath, Promise promise) { } catch (Exception e) { Log.e("E_RNThumnail_ERROR", e.getMessage()); promise.reject("E_RNThumnail_ERROR", e); - } + } } }