From cdf7031e4e3b4cc9dc72c42837deb2e2e8f7e988 Mon Sep 17 00:00:00 2001 From: Ji Jia Jia Date: Tue, 17 Feb 2026 09:16:36 +0100 Subject: [PATCH 1/2] add commented methods to interface --- doc/02_Upgrade_Notes/README.md | 3 +++ .../Models/Asset/AssetResolverContractInterface.php | 4 ++++ .../DataObject/ConcreteObjectResolverContractInterface.php | 6 ++++++ .../DataObjectFolderResolverContractInterface.php | 4 ++++ .../Models/Document/DocumentResolverContractInterface.php | 5 +++++ 5 files changed, 22 insertions(+) diff --git a/doc/02_Upgrade_Notes/README.md b/doc/02_Upgrade_Notes/README.md index 9592a78..807ca69 100644 --- a/doc/02_Upgrade_Notes/README.md +++ b/doc/02_Upgrade_Notes/README.md @@ -1,5 +1,8 @@ # Upgrade notes +## 3.5.0 +- Added commented methods in interfaces for upcoming introduction of getter/setter of `GetInheritedProperties` in AssetResolverContractInterface, ConcreteObjectResolverContractInterface, DataObjectFolderResolverContractInterface, DocumentResolverContractInterface. + ## 2.0.0 All Resolver classes and interfaces will be marked as `@internal` diff --git a/src/Contract/Models/Asset/AssetResolverContractInterface.php b/src/Contract/Models/Asset/AssetResolverContractInterface.php index 685785c..59ea75c 100644 --- a/src/Contract/Models/Asset/AssetResolverContractInterface.php +++ b/src/Contract/Models/Asset/AssetResolverContractInterface.php @@ -33,4 +33,8 @@ public function create(int $parentId, array $data = [], bool $save = true): Asse public function getById(int $id, array $params = []): ?Asset; public function locateDaoClass(string $modelClass): ?string; + +// public function getGetInheritedProperties(): bool; + +// public function setGetInheritedProperties(bool $getInheritedProperties): void; } diff --git a/src/Contract/Models/DataObject/ConcreteObjectResolverContractInterface.php b/src/Contract/Models/DataObject/ConcreteObjectResolverContractInterface.php index 120401d..9637b04 100644 --- a/src/Contract/Models/DataObject/ConcreteObjectResolverContractInterface.php +++ b/src/Contract/Models/DataObject/ConcreteObjectResolverContractInterface.php @@ -29,6 +29,12 @@ public function setHideUnpublished(bool $hideUnpublished): void; public function doHideUnpublished(): bool; + +// public function getGetInheritedProperties(): bool; + +// public function setGetInheritedProperties(bool $getInheritedProperties): void; + + public function setGetInheritedValues(bool $getInheritedValues): void; public function getGetInheritedValues(): bool; diff --git a/src/Contract/Models/DataObject/DataObjectFolderResolverContractInterface.php b/src/Contract/Models/DataObject/DataObjectFolderResolverContractInterface.php index ee6e9f6..6eff53b 100644 --- a/src/Contract/Models/DataObject/DataObjectFolderResolverContractInterface.php +++ b/src/Contract/Models/DataObject/DataObjectFolderResolverContractInterface.php @@ -30,6 +30,10 @@ public function setHideUnpublished(bool $hideUnpublished): void; public function doHideUnpublished(): bool; +// public function getGetInheritedProperties(): bool; + +// public function setGetInheritedProperties(bool $getInheritedProperties): void; + public function setGetInheritedValues(bool $getInheritedValues): void; public function getGetInheritedValues(): bool; diff --git a/src/Contract/Models/Document/DocumentResolverContractInterface.php b/src/Contract/Models/Document/DocumentResolverContractInterface.php index 0f42996..fe98e12 100644 --- a/src/Contract/Models/Document/DocumentResolverContractInterface.php +++ b/src/Contract/Models/Document/DocumentResolverContractInterface.php @@ -39,4 +39,9 @@ public function getTypesConfiguration(): array; public function doHideUnpublished(): bool; public function locateDaoClass(string $modelClass): ?string; + +// public function getGetInheritedProperties(): bool; + +// public function setGetInheritedProperties(bool $getInheritedProperties): void; + } From 26ce00867a2e9fc30fa672df4b41eb55d5fc828c Mon Sep 17 00:00:00 2001 From: Ji Jia Jia Date: Tue, 17 Feb 2026 09:19:39 +0100 Subject: [PATCH 2/2] add commented methods to interface --- src/Contract/Models/Asset/AssetResolverContractInterface.php | 2 ++ .../DataObject/ConcreteObjectResolverContractInterface.php | 2 ++ .../DataObject/DataObjectFolderResolverContractInterface.php | 2 ++ .../Models/Document/DocumentResolverContractInterface.php | 2 ++ 4 files changed, 8 insertions(+) diff --git a/src/Contract/Models/Asset/AssetResolverContractInterface.php b/src/Contract/Models/Asset/AssetResolverContractInterface.php index 59ea75c..95d29f4 100644 --- a/src/Contract/Models/Asset/AssetResolverContractInterface.php +++ b/src/Contract/Models/Asset/AssetResolverContractInterface.php @@ -34,7 +34,9 @@ public function getById(int $id, array $params = []): ?Asset; public function locateDaoClass(string $modelClass): ?string; +// BC-Break: This method will be introduced in v4.0.0 // public function getGetInheritedProperties(): bool; +// BC-Break: This method will be introduced in v4.0.0 // public function setGetInheritedProperties(bool $getInheritedProperties): void; } diff --git a/src/Contract/Models/DataObject/ConcreteObjectResolverContractInterface.php b/src/Contract/Models/DataObject/ConcreteObjectResolverContractInterface.php index 9637b04..5a378bf 100644 --- a/src/Contract/Models/DataObject/ConcreteObjectResolverContractInterface.php +++ b/src/Contract/Models/DataObject/ConcreteObjectResolverContractInterface.php @@ -30,8 +30,10 @@ public function setHideUnpublished(bool $hideUnpublished): void; public function doHideUnpublished(): bool; +// BC-Break: This method will be introduced in v4.0.0 // public function getGetInheritedProperties(): bool; +// BC-Break: This method will be introduced in v4.0.0 // public function setGetInheritedProperties(bool $getInheritedProperties): void; diff --git a/src/Contract/Models/DataObject/DataObjectFolderResolverContractInterface.php b/src/Contract/Models/DataObject/DataObjectFolderResolverContractInterface.php index 6eff53b..bbdd918 100644 --- a/src/Contract/Models/DataObject/DataObjectFolderResolverContractInterface.php +++ b/src/Contract/Models/DataObject/DataObjectFolderResolverContractInterface.php @@ -30,8 +30,10 @@ public function setHideUnpublished(bool $hideUnpublished): void; public function doHideUnpublished(): bool; +// BC-Break: This method will be introduced in v4.0.0 // public function getGetInheritedProperties(): bool; +// BC-Break: This method will be introduced in v4.0.0 // public function setGetInheritedProperties(bool $getInheritedProperties): void; public function setGetInheritedValues(bool $getInheritedValues): void; diff --git a/src/Contract/Models/Document/DocumentResolverContractInterface.php b/src/Contract/Models/Document/DocumentResolverContractInterface.php index fe98e12..c716675 100644 --- a/src/Contract/Models/Document/DocumentResolverContractInterface.php +++ b/src/Contract/Models/Document/DocumentResolverContractInterface.php @@ -40,8 +40,10 @@ public function doHideUnpublished(): bool; public function locateDaoClass(string $modelClass): ?string; +// BC-Break: This method will be introduced in v4.0.0 // public function getGetInheritedProperties(): bool; +// BC-Break: This method will be introduced in v4.0.0 // public function setGetInheritedProperties(bool $getInheritedProperties): void; }