Skip to content

Add warnings to material texture slots based on sRGB conflicts (color space). #1693

@Maksims

Description

@Maksims

I've been caught numerous times when various textures that should not be sRGB, especially normal maps, were marked sRGB when uploaded.
Which leads to wrong shading, and it is not apparent to user why things look bad with normals, you might go look into Tangents issues, etc.

To mitigate this, UX for sRGB stuff should be improved. Current approach to bombard user with warnings in some console panel - is not a solution. I've noticed that nobody pretty much goes there, because many of these warnings are "ok" and not relevant, so it becomes a dump of some logs - not usable.

What needs to be done, is in-context UX elements, that help to mitigate these issues.
The most common place where it is needed - are the slots in material inspector.

Use consistent icon (yellow triangle with exclamation mark). Use meaningful tooltip text on hover based on context.
Ensure the icon and tooltip is updated when things are changed (texture sRGB changes, material slot changes, etc).

If slot expected sRGB does not match provided texture sRGB, provide an icon to indicate for that. Which on hover also would have a small text, something: "Texture is expected be in sRGB color space.", or the opposite, where provided texture is in sRGB and expected without.

Image

In Assets Panel, after the filename:

Image Image

In texture inspector, if texture is used in mismatching way, indicate that also:

Image

Metadata

Metadata

Assignees

No one assigned

    Labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions