Inconsistent Parameter for EnvLighting.generateLightingSource in Skybox Initialization

[gameatp]

There is an inconsistency in the parameter passed to EnvLighting.generateLightingSource when initializing a skybox:
The original implementation uses the raw Texture source directly: EnvLighting.generateLightingSource(source)
However, the editor's implementation uses the cubemap generated from the source: EnvLighting.generateLightingSource(skybox)
Could you clarify which parameter (raw Texture or generated cubemap) is the correct and intended input for EnvLighting.generateLightingSource in this skybox initialization context? Also, is there any functional impact (e.g., lighting quality, performance) between these two approaches?

[gameatp]

private initSkybox(source: Texture) {
        const skybox = EnvLighting.generateSkyboxCubemap(source);
        const lighting = EnvLighting.generateLightingSource(source);
        // The second options parameter should not be necessary but the TS declarations require it for now
        const envAtlas = EnvLighting.generateAtlas(lighting, {});
        lighting.destroy();
        this.app.scene.envAtlas = envAtlas;
        this.app.scene.skybox = skybox;

        this.renderNextFrame();
    }

vs

  private initSkybox(source: Texture) { 
        const device = this.app.graphicsDevice;
        const skybox = EnvLighting.generateSkyboxCubemap(source);
        const lighting = EnvLighting.generateLightingSource(skybox);
        lighting.anisotropy = device.maxAnisotropy;
        // The second options parameter should not be necessary but the TS declarations require it for now
        const envAtlas = EnvLighting.generateAtlas(lighting, {});
        lighting.destroy();
        this.app.scene.envAtlas = envAtlas;
        this.app.scene.skybox = skybox;

        this.renderNextFrame();
    }

[slimbuck]

There is very little difference between these two approaches and should result in the same lighting.

Performance is probably very similar too.

In the one case lighting texture is prepared from the skybox cubemap and the other case from the skybox source. 🤷🏽

[gameatp]

There is very little difference between these two approaches and should result in the same lighting.

Performance is probably very similar too.

In the one case lighting texture is prepared from the skybox cubemap and the other case from the skybox source. 🤷🏽

While performance may be comparable, I’ve run tests and found the resulting lighting textures have a significant difference in visual quality between using the skybox cubemap vs. the original skybox source.

[slimbuck]

oh that's interesting. when I originally wrote the lighting preprocessor I thought using the lightingSource was crucial but later on found it didn't make a big difference.

could you share your original cubemap that has very different results so I can investigate?

[gameatp]

哦，这很有意思。我最初编写光照预处理器时，认为使用 lightSource 至关重要，但后来发现它并没有太大区别。

能否分享一下你那张结果截然不同的原始立方体贴图，以便我进行调查？

[gameatp]

The first image uses the code below and is obviously much brighter, with the sky from the "Tank Farm" image applied to it.

private initSkybox(source: Texture) {
    const skybox = EnvLighting.generateSkyboxCubemap(source);
    const lighting = EnvLighting.generateLightingSource(source);
    // The second options parameter should not be necessary but the TS declarations require it for now
    const envAtlas = EnvLighting.generateAtlas(lighting, {});
    lighting.destroy();
    this.app.scene.envAtlas = envAtlas;
    this.app.scene.skybox = skybox;

    this.renderNextFrame();
}

[gameatp]

You may adjust this code to check the next model at random and make a comparison with it.