Skip to content

fix: added resize behaviour to the textarea #467

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
SikindarMirza-p44 wants to merge 2 commits into
base: main
Choose a base branch
from
Open

fix: added resize behaviour to the textarea #467

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
9c5c19a
fix: added resize behaviour to the textarea
SikindarMirza-p44 Sep 21, 2023
fa58534
chore: added changeset
SikindarMirza-p44 Sep 21, 2023
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
5 changes: 5 additions & 0 deletions .changeset/eighty-terms-vanish.md
View file
Open in desktop
Original file line number Diff line number Diff line change
@@ -0,0 +1,5 @@
---
'@project44-manifest/react': patch
---

fix: added resize behaviour to TextArea
1 change: 1 addition & 0 deletions packages/react/src/components/TextArea/TextArea.styles.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -2,6 +2,7 @@ import { css, pxToRem } from '@project44-manifest/react-styles';

export const useStyles = css({
'.manifest-textfield-base__input': {
resize: 'both',
minHeight: pxToRem(56),
Copy link
Contributor

@vitaliy-p44 vitaliy-p44 Sep 22, 2023

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

It may break the UX for existing TextArea usages which are not expecting this.
If you want to have it in manifest, it's better to make it as configured prop - resize?: 'none' | 'vertical' | 'horizontal' | 'both' defaults to none. or just override the prop in place where you need that with styled function or inline override like this: <TextArea css={{ textarea: { resize: 'both' } }} />

},
});