-
Notifications
You must be signed in to change notification settings - Fork 5
Description
Per conversation that has happened in interal PL Slack, there is a move to more proactively close project proposals that aren't in our short term priority list. There were a couple of concerns raised about this around discoverability:
- By closing without merging, we can't open a directory of proposals and search over them with all the tools there are for searching in files.
- There isn't an easy way to identify the closed PR's that didn't get selected. For example, a search like is:closed project:protocol/web3-dev-team/3 doesn't pull these items up because these closed items have been removed from the board. Example: propose: js projects configuration #82
A proposal that was discussed was:
For items that aren't on the short-term priority list:
- close out the PR with a note that you can re-open it and add a “Review” section like:
## Review
### YYYY-MM-DD
$textOnTheCurentState
- Add to a “future” directory
- Merge it
A couple of notes:
- We are effectively letting the author's willingness to make these slight updates as a signal for how willingly we are to invest in it for the future vs. just letting it fully closeout.
- Putting issues in a different directory makes it easy to distinguish between things we finish and things we flushed out but put on the backlog.
One other thought: for PR's that we're closing because they're not a short-term priority, should we maybe put them in a special column (e.g., "Closed: Not Short Term Priority")? I'm suggesting this because otherwise it becomes harder for someone to identify which PRs were closed for this reason. For example, a search like is:closed -project:protocol/web3-dev-team/3 has other cruft.
If a proposal like the above gets adopted, I assume it results in:
- Updates to https://github.com/protocol/web3-dev-team/blob/main/README.md
- Adding some extra text to all the PR's we just closed
Cc'ing @mikeal, @jacobheun, @warpfork, @momack2, @Stebalien as folks who have had engagement in this conversation.