feat(fetch-messages): add encode_channels parameter

Add the `encode_channels` parameter for `fetch` to enable or disable channel names percent-encoding
in response.

Author: parfeon

lib/pubnub/event.rb

@@ -178,7 +178,7 @@ def create_variables_from_options(options)
                      include_custom_message_type include_message_actions include_message_type
                      replicate with_presence cipher_key_selector include_meta include_uuid join
                      update get add remove push_token push_gateway environment topic
-                     authorized_uuid authorized_user_id token type status value]
+                     authorized_uuid authorized_user_id token type status value encode_channels]
 
       options = options.each_with_object({}) { |option, obj| obj[option.first.to_sym] = option.last }
 

lib/pubnub/events/fetch_messages.rb

@@ -13,6 +13,7 @@ def initialize(options, app)
       @include_custom_message_type = options.fetch(:include_custom_message_type, false)
       @include_message_actions = options.fetch(:include_message_actions, false)
       @include_message_type = options.fetch(:include_message_type, true)
+      @encode_channels = options.fetch(:encode_channels, true)
       @include_uuid = options.fetch(:include_uuid, true)
       @include_meta = options.fetch(:include_meta, false)
       @start = options[:start] if options.key?(:start)
@@ -52,6 +53,7 @@ def parameters(signature = false)
       parameters[:include_uuid] = 'true' if @include_uuid
       parameters[:include_custom_message_type] = 'true' if @include_custom_message_type
       parameters[:include_message_type] = 'true' if @include_message_type
+      parameters[:encode_channels] = 'false' if !@encode_channels && !@include_message_actions
       parameters[:start] = @start unless @start.nil?
       parameters[:end] = @end unless @end.nil?
       parameters[:max] = @max unless @max.nil?

spec/examples/fetch_messages_examples_spec.rb

@@ -596,4 +596,60 @@
                                                ] } })
     end
   end
+
+  it "__channel__channel|encoded::1___max__5___http_sync__true___callback__nil_" do
+    VCR.use_cassette("examples/fetch_messages/encoded_channels", :record => :once) do
+      channel = "channel|encoded::1"
+      envelope = @pubnub.fetch_messages(channel: channel, max: 5, http_sync: true)
+      expect(envelope.is_a?(Pubnub::Envelope)).to eq true
+      expect(envelope.error?).to eq false
+
+      expect(envelope.status[:code]).to eq(200)
+      expect(envelope.status[:category]).to eq(:ack)
+      expect(envelope.status[:config]).to eq({ :tls => false, :uuid => "ruby-test-uuid-client-one", :auth_key => "ruby-test-auth-client-one", :origin => "ps.pndsn.com" })
+
+      expect(envelope.result[:code]).to eq(200)
+      expect(envelope.result[:operation]).to eq(:fetch_messages)
+      expect(envelope.result[:data]).to eq({
+                                             :channels => {
+                                               "channel%7Cencoded%3A%3A1" => [
+                                                 {
+                                                   "message_type" => nil,
+                                                   "message" => "Hello test world",
+                                                   "timetoken" => "17575837829949324",
+                                                   "uuid" => "ruby-test-uuid-client-one"
+                                                 }
+                                               ]
+                                             }
+                                           })
+    end
+  end
+
+  it "__channel__channel|encoded::2___max__5___encode_channels__false___http_sync__true___callback__nil_" do
+    VCR.use_cassette("examples/fetch_messages/not_encoded_channels", :record => :once) do
+      channel = "channel|encoded::2"
+      envelope = @pubnub.fetch_messages(channel: channel, max: 5, encode_channels: false, http_sync: true)
+      expect(envelope.is_a?(Pubnub::Envelope)).to eq true
+      expect(envelope.error?).to eq false
+
+      expect(envelope.status[:code]).to eq(200)
+      expect(envelope.status[:category]).to eq(:ack)
+      expect(envelope.status[:config]).to eq({ :tls => false, :uuid => "ruby-test-uuid-client-one", :auth_key => "ruby-test-auth-client-one", :origin => "ps.pndsn.com" })
+
+      expect(envelope.result[:code]).to eq(200)
+      expect(envelope.result[:operation]).to eq(:fetch_messages)
+      expect(envelope.result[:data]).to eq({
+                                             :channels => {
+                                               "channel|encoded::2" => [
+                                                 {
+                                                   "message_type" => nil,
+                                                   "message" => "Hello test world",
+                                                   "timetoken" => "17575842502404510",
+                                                   "uuid" => "ruby-test-uuid-client-one",
+                                                 }
+                                               ]
+                                             }
+                                           })
+    end
+  end
 end