From 886960fa14a72253a2ed68574fa283adc062c58e Mon Sep 17 00:00:00 2001 From: Sebastian Rittau Date: Fri, 18 Oct 2024 12:00:51 +0200 Subject: [PATCH 1/9] Use Python 3.12 for third-party checks --- .github/workflows/daily.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/daily.yml b/.github/workflows/daily.yml index 2062b58e0869..f513a1ddc7ee 100644 --- a/.github/workflows/daily.yml +++ b/.github/workflows/daily.yml @@ -67,9 +67,7 @@ jobs: - uses: actions/checkout@v4 - uses: actions/setup-python@v5 with: - # TODO: Use Python 3.12. As of 2024-03-08, several third-party - # packages fail to install with Python 3.12. - python-version: "3.11" + python-version: "3.12" cache: pip cache-dependency-path: | requirements-tests.txt From 18603acce541237daa83ff31cc79923337ea0675 Mon Sep 17 00:00:00 2001 From: Sebastian Rittau Date: Fri, 18 Oct 2024 12:01:09 +0200 Subject: [PATCH 2/9] Use Python 3.12 for third-party checks --- .github/workflows/stubtest_third_party.yml | 4 +--- 1 file changed, 1 insertion(+), 3 deletions(-) diff --git a/.github/workflows/stubtest_third_party.yml b/.github/workflows/stubtest_third_party.yml index 0b45a90c7afd..4b4b1dd0e47b 100644 --- a/.github/workflows/stubtest_third_party.yml +++ b/.github/workflows/stubtest_third_party.yml @@ -41,9 +41,7 @@ jobs: fetch-depth: 0 - uses: actions/setup-python@v5 with: - # TODO: Use Python 3.12. As of 2024-03-08, several third-party - # packages fail to install with Python 3.12. - python-version: "3.11" + python-version: "3.12" cache: pip cache-dependency-path: | requirements-tests.txt From 70b5f23a82e14626a6aee12044ec0afcadef321d Mon Sep 17 00:00:00 2001 From: Sebastian Rittau Date: Fri, 18 Oct 2024 12:52:46 +0200 Subject: [PATCH 3/9] Disable stubtest for atheris --- stubs/atheris/METADATA.toml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/stubs/atheris/METADATA.toml b/stubs/atheris/METADATA.toml index 5a014d0c8f63..ab26018e6685 100644 --- a/stubs/atheris/METADATA.toml +++ b/stubs/atheris/METADATA.toml @@ -4,3 +4,5 @@ partial_stub = true [tool.stubtest] ignore_missing_stub = true +# TODO: Does not compile with Python 3.12 as of 2024-10-18 (release 2.3.0). +skip = true From 33d41310e3acfe10cc340431ef87f6ae7101ad25 Mon Sep 17 00:00:00 2001 From: Sebastian Rittau Date: Fri, 18 Oct 2024 12:53:29 +0200 Subject: [PATCH 4/9] Skip playsound --- stubs/playsound/METADATA.toml | 5 +++++ 1 file changed, 5 insertions(+) diff --git a/stubs/playsound/METADATA.toml b/stubs/playsound/METADATA.toml index 14175f7d7a16..4e5ac4869391 100644 --- a/stubs/playsound/METADATA.toml +++ b/stubs/playsound/METADATA.toml @@ -1,2 +1,7 @@ version = "1.3.*" upstream_repository = "https://github.com/TaylorSMarks/playsound" + +[tool.stubtest] +ignore_missing_stub = true +# TODO: Does not compile with Python 3.12 as of 2024-10-18 (release 1.3.0). +skip = true From cf17d6d86120e2d61995c39564790b1496c54375 Mon Sep 17 00:00:00 2001 From: Sebastian Rittau Date: Fri, 18 Oct 2024 12:56:53 +0200 Subject: [PATCH 5/9] Skip stubtest for boto --- stubs/boto/METADATA.toml | 2 ++ 1 file changed, 2 insertions(+) diff --git a/stubs/boto/METADATA.toml b/stubs/boto/METADATA.toml index 56aaba050a58..8f20c7adba58 100644 --- a/stubs/boto/METADATA.toml +++ b/stubs/boto/METADATA.toml @@ -5,3 +5,5 @@ partial_stub = true [tool.stubtest] ignore_missing_stub = true +# TODO: Does not import with Python 3.12 as of 2024-10-18 (release 2.49.0). +skip = true From 0f1fe4d6f0661e1764744b12f4246a5f5fb8c32b Mon Sep 17 00:00:00 2001 From: Sebastian Rittau Date: Fri, 18 Oct 2024 13:09:03 +0200 Subject: [PATCH 6/9] Update stubtest_allowlist.txt for Python 3.12 --- stubs/requests/@tests/stubtest_allowlist.txt | 3 --- 1 file changed, 3 deletions(-) diff --git a/stubs/requests/@tests/stubtest_allowlist.txt b/stubs/requests/@tests/stubtest_allowlist.txt index 667b6b8ae327..3bfd86463261 100644 --- a/stubs/requests/@tests/stubtest_allowlist.txt +++ b/stubs/requests/@tests/stubtest_allowlist.txt @@ -2,6 +2,3 @@ requests.packages.mod requests.packages.package requests.packages.target - -# Alias for builtins.bytes -requests.compat.bytes.__buffer__ From 0e788a44e49e9c817429371ba310a2b40d1b7fa2 Mon Sep 17 00:00:00 2001 From: Sebastian Rittau Date: Fri, 18 Oct 2024 13:09:52 +0200 Subject: [PATCH 7/9] Update stubtest_allowlist.txt for Python 3.12 --- stubs/openpyxl/@tests/stubtest_allowlist.txt | 4 ---- 1 file changed, 4 deletions(-) diff --git a/stubs/openpyxl/@tests/stubtest_allowlist.txt b/stubs/openpyxl/@tests/stubtest_allowlist.txt index 1a9bcaf7b121..d548945f4d0c 100644 --- a/stubs/openpyxl/@tests/stubtest_allowlist.txt +++ b/stubs/openpyxl/@tests/stubtest_allowlist.txt @@ -195,7 +195,3 @@ openpyxl.worksheet.smart_tag.CellSmartTagPr.__init__ openpyxl.worksheet.smart_tag.CellSmartTags.__init__ openpyxl.worksheet.table.TableColumn.__init__ openpyxl.worksheet.table.XMLColumnProps.__init__ - -# Inherited from the stdlib, where we lie about the presence -# of this method in order to mark it as deprecated. -openpyxl.xml.functions.Element.__bool__ From a80840d74b24bd4e35b8c6abf7c89eb6c7ad108e Mon Sep 17 00:00:00 2001 From: Sebastian Rittau Date: Fri, 18 Oct 2024 18:43:29 +0200 Subject: [PATCH 8/9] Link atheris PR --- stubs/atheris/METADATA.toml | 1 + 1 file changed, 1 insertion(+) diff --git a/stubs/atheris/METADATA.toml b/stubs/atheris/METADATA.toml index ab26018e6685..52458d522e5a 100644 --- a/stubs/atheris/METADATA.toml +++ b/stubs/atheris/METADATA.toml @@ -5,4 +5,5 @@ partial_stub = true [tool.stubtest] ignore_missing_stub = true # TODO: Does not compile with Python 3.12 as of 2024-10-18 (release 2.3.0). +# https://github.com/google/atheris/pull/60 skip = true From 96f9e070b749ac99ce55d269269f7d6cf3c7b4c9 Mon Sep 17 00:00:00 2001 From: Sebastian Rittau Date: Tue, 3 Dec 2024 15:29:51 +0100 Subject: [PATCH 9/9] Skip gdb stubtest --- stubs/gdb/METADATA.toml | 13 +++++++++++++ 1 file changed, 13 insertions(+) diff --git a/stubs/gdb/METADATA.toml b/stubs/gdb/METADATA.toml index 8aa64fa66bab..6d126b461643 100644 --- a/stubs/gdb/METADATA.toml +++ b/stubs/gdb/METADATA.toml @@ -13,3 +13,16 @@ extra_description = """\ [tool.stubtest] platforms = ["linux"] apt_dependencies = ["gdb"] +# stubtest fails for unknown reasons after upgrading to use Python 3.12: +# +# Traceback (most recent call last): +# File "/tmp/stubtest-4m851njl/gdb_stubtest.py", line 22, in +# from mypy.stubtest import main +# File "/tmp/stubtest-4m851njl/lib/python3.12/site-packages/mypy/stubtest.py", line 30, in +# from pathlib import Path +# File "/usr/lib/python3.12/pathlib.py", line 19, in +# from urllib.parse import quote_from_bytes as urlquote_from_bytes +# File "/usr/lib/python3.12/urllib/parse.py", line 36, in +# import math +# ModuleNotFoundError: No module named 'math' +skip = true