-
Notifications
You must be signed in to change notification settings - Fork 28
Closed
Description
Just creating an issue tracking what needs to be done before a 0.6.0 release. My plan is to have this release be at least (semi-stable) and potentially we could think about a 1.0.0 release not to long after. With a 1.0.0 pyxem/ kikuchipy releases in the future we probably need a more stable diffsims package as well...
Package Maintenance etc.
- Add Deprecations #199
- Add in pre-commit CI to automatically use
blackformatting #202 - Add Examples to documentation using Sphinx Gallery Use phase class #201
Redesign Simulations:
- Use orix
Phaseclass inDiffractionGeneratorUse phase class #201 - Move sampling methods to
orixAdd Sampling orix#460 - Allow Diffraction generator to pull much of the needed information from the
Phaseclass. Use phase class #201 - Add functionality to DiffractionLibrary
- Add more descriptive repr
- Add method to get simulation_index in polar representation Use phase class #201
- Add a method to visualize the DiffractionLibrary --> use some orix functionality?
Refactors:
- Move
AtomicDiffractionGeneratorto its own file. I'm not sure if this really should be in diffsims. With packages likeabTEMwhich do this quite a bit better this seems a bit redundant. But maybe others disagree?
Removals/Deprecations:
- Deprecate
StructureLibrary--> Removal in 0.7.0 - Remove
ReciprocalLatticePointper deprecation warning - Deprecate
rotation_list_generators,sphere_mesh_generatorsandzap_map_generatorsAll sampling should be moved toorix - Deprecate
VectorLibrary-->Removal in 0.7.0 (I think the VectorLibrary is just another instance of the - Remove
AtomicDiffractionGenerator??? This functionality is a bit hard to maintain??? Considering things like abTEM exist I'd consider removing this if there isn't too much objection as you can just do a dynamical simulation...
Reactions are currently unavailable