Not Compatible with Apache Superset 4.1.1 or 5.0.0

[raycardillo]

After getting all setup, there are many errors. I may try to workaround some manually, but it's not looking good on several levels.

When trying to create a new dataset (when it tries to fetch data for browsing) I get errors like this:

  File "/home/superset/.venv/lib/python3.11/site-packages/qdb_superset/db_engine_specs/questdb.py", line 293, in select_star
    return super().select_star(
           ^^^^^^^^^^^^^^^^^^^^
TypeError: BaseEngineSpec.select_star() takes from 4 to 9 positional arguments but 10 were given

When trying to use SQL Lab I get errors like this:

questdb error: QuestDbEngineSpec.execute() takes 3 positional arguments but 4 were given

This may be triggered by:
Issue 1002 - The database returned an unexpected error. 

When trying to click on the table name in the browser, get an error in the UI and the logs:

  File "/home/superset/.venv/lib/python3.11/site-packages/flask/ctx.py", line 353, in match_request
    result = self.url_adapter.match(return_rule=True)  # type: ignore
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/superset/.venv/lib/python3.11/site-packages/werkzeug/routing/map.py", line 629, in match
    raise NotFound() from None
werkzeug.exceptions.NotFound: 404 Not Found: The requested URL was not found on the server. If you entered the URL manually please check your spelling and try again.

[raycardillo]

FYI, when I downgraded to Superset 4.0.2, these problems went away, but it stinks that I cannot use the latest release and all the new features until this is resolved.

[raycardillo]

Was taking another look at 5.0.0rc1 tonight and captured a full log around this issue.

2025-03-14 21:25:21,295:INFO:superset.sql_lab:Query 2: Running statement 1 out of 1
2025-03-14 21:25:21,329:WARNING:superset.views.error_handling:SupersetErrorsException
Traceback (most recent call last):
  File "/home/superset5/.venv/lib/python3.12/site-packages/flask/app.py", line 1484, in full_dispatch_request
    rv = self.dispatch_request()
         ^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/superset5/.venv/lib/python3.12/site-packages/flask/app.py", line 1469, in dispatch_request
    return self.ensure_sync(self.view_functions[rule.endpoint])(**view_args)
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/superset5/.venv/lib/python3.12/site-packages/flask_appbuilder/security/decorators.py", line 109, in wraps
    return f(self, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/superset5/.venv/lib/python3.12/site-packages/superset/views/base_api.py", line 120, in wraps
    duration, response = time_function(f, self, *args, **kwargs)
                         ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/superset5/.venv/lib/python3.12/site-packages/superset/utils/core.py", line 1363, in time_function
    response = func(*args, **kwargs)
               ^^^^^^^^^^^^^^^^^^^^^
  File "/home/superset5/.venv/lib/python3.12/site-packages/superset/views/base_api.py", line 92, in wraps
    return f(self, *args, **kwargs)
           ^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/superset5/.venv/lib/python3.12/site-packages/superset/utils/log.py", line 303, in wrapper
    value = f(*args, **kwargs)
            ^^^^^^^^^^^^^^^^^^
  File "/home/superset5/.venv/lib/python3.12/site-packages/superset/sqllab/api.py", line 409, in execute_sql_query
    command_result: CommandResult = command.run()
                                    ^^^^^^^^^^^^^
  File "/home/superset5/.venv/lib/python3.12/site-packages/superset/utils/decorators.py", line 266, in wrapped
    return on_error(ex)
           ^^^^^^^^^^^^
  File "/home/superset5/.venv/lib/python3.12/site-packages/superset/utils/decorators.py", line 236, in on_error
    raise ex
  File "/home/superset5/.venv/lib/python3.12/site-packages/superset/utils/decorators.py", line 259, in wrapped
    result = func(*args, **kwargs)
             ^^^^^^^^^^^^^^^^^^^^^
  File "/home/superset5/.venv/lib/python3.12/site-packages/superset/commands/sql_lab/execute.py", line 105, in run
    status = self._run_sql_json_exec_from_scratch()
             ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/superset5/.venv/lib/python3.12/site-packages/superset/commands/sql_lab/execute.py", line 158, in _run_sql_json_exec_from_scratch
    return self._sql_json_executor.execute(
           ^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^^
  File "/home/superset5/.venv/lib/python3.12/site-packages/superset/sqllab/sql_json_executer.py", line 110, in execute
    raise SupersetErrorsException(
superset.exceptions.SupersetErrorsException: [SupersetError(message='questdb error: QuestDbEngineSpec.execute() takes 3 positional arguments but 4 were given', error_type=<SupersetErrorType.GENERIC_DB_ENGINE_ERROR: 'GENERIC_DB_ENGINE_ERROR'>, level=<ErrorLevel.ERROR: 'error'>, extra={'engine_name': 'QuestDB', 'issue_codes': [{'code': 1002, 'message': 'Issue 1002 - The database returned an unexpected error.'}]})]

[oliveiraethales]

Hi @raycardillo, #34 should fix this. In the meantime, you can manually change the files in your local environment to match that of the PRs.