fixes for covar methods + bump version, update NEWS

Author: Enchufa2

DESCRIPTION

@@ -1,7 +1,7 @@
 Package: quantities
 Type: Package
 Title: Quantity Calculus for R Vectors
-Version: 0.2.2
+Version: 0.2.3
 Authors@R: c(
     person("Iñaki", "Ucar", email="iucar@fedoraproject.org",
       role=c("aut", "cph", "cre"), comment=c(ORCID="0000-0001-6403-5550")))

NAMESPACE

@@ -23,6 +23,8 @@ S3method(as.list,quantities)
 S3method(as.matrix,quantities)
 S3method(c,quantities)
 S3method(cbind,quantities)
+S3method(correl,quantities)
+S3method(covar,quantities)
 S3method(diff,quantities)
 S3method(drop_errors,quantities)
 S3method(drop_quantities,data.frame)

NEWS.md

@@ -1,3 +1,7 @@
+# quantities 0.2.3
+
+- Fixes for `covar` and `correl` implementations.
+
 # quantities 0.2.2
 
 - Performance improvements for `data.frame` methods.

R/errors.R

@@ -99,6 +99,12 @@ errors_min.units <- function(x)
 #' correl(x, y)
 #' covar(x, y)
 #'
+#' @name correl
+#' @export
+correl.quantities <- function(x, y) {
+  NextMethod()
+}
+
 #' @name correl
 #' @export
 `correl<-.quantities` <- function(x, y, value) {
@@ -109,11 +115,20 @@ errors_min.units <- function(x)
   NextMethod()
 }
 
+#' @name correl
+#' @export
+covar.quantities <- function(x, y) {
+  if (!is.null(xy <- NextMethod()))
+    units(xy) <- as_units(units(x)) * as_units(units(y))
+  xy
+}
+
 #' @name correl
 #' @export
 `covar<-.quantities` <- function(x, y, value) {
   stopifnot(inherits(y, "quantities"))
   stopifnot(inherits(value, "units"))
-  stopifnot(ud_are_convertible(units(value), units(x*y)))
+  units(value) <- units(x*y)
+  value <- drop_units(value)
   NextMethod()
 }

man/correl.Rd

@@ -1,4 +1,5 @@
 Version: 1.0
+ProjectId: 433c14c0-a10f-4673-8146-09557d5bfd2f
 
 RestoreWorkspace: Default
 SaveWorkspace: Default