Makefile: Vala code generated tries to include sdb.h at wrong path

[dora-meowmeow]

Note: This issue seems to be only happening with make and Makefile. Compiling with meson does not have this issue.
During compiling of SDB, when vala generates the c source files it seems to try to include "sdb.h" at bindings/vala/types/sdbinstance.c.

bindings/vala/types/sdbinstance.c

/* sdbinstance.c generated by valac 0.56.18, the Vala compiler
 * generated from sdbinstance.vala, do not modify */

#include "sdbtypes.h"
#include "sdb.h"
#include <glib.h>

This should be corrected to

/* sdbinstance.c generated by valac 0.56.18, the Vala compiler
 * generated from sdbinstance.vala, do not modify */

#include "sdbtypes.h"
-#include "sdb.h"
+#include "../../../include/sdb/sdb.h"
#include <glib.h>

Error:

In file included from /usr/include/glib-2.0/glib/gthread.h:34,
                 from /usr/include/glib-2.0/glib/gasyncqueue.h:34,
                 from /usr/include/glib-2.0/glib.h:34,
                 from /usr/include/glib-2.0/gobject/gbinding.h:30,
                 from /usr/include/glib-2.0/glib-object.h:24,
                 from /builddir/sdb-2.0.1/bindings/vala/types/sdbtypes.h:6,
                 from /builddir/sdb-2.0.1/bindings/vala/types/iterable.c:4:
/builddir/sdb-2.0.1/bindings/vala/types/iterable.c: In function 'sdb_types_iterable_get_type':
/usr/include/glib-2.0/glib/gatomic.h:131:5: warning: argument 2 of '__atomic_load' discards 'volatile' qualifier [-Wdiscarded-qualifiers]
  131 |     __atomic_load (gapg_temp_atomic, &gapg_temp_newval, __ATOMIC_SEQ_CST); \
      |     ^~~~~~~~~~~~~
/usr/include/glib-2.0/glib/gthread.h:274:7: note: in expansion of macro 'g_atomic_pointer_get'
  274 |     (!g_atomic_pointer_get (location) &&                             \
      |       ^~~~~~~~~~~~~~~~~~~~
/builddir/sdb-2.0.1/bindings/vala/types/iterable.c:82:13: note: in expansion of macro 'g_once_init_enter'
   82 |         if (g_once_init_enter (&sdb_types_iterable_type_id__once)) {
      |             ^~~~~~~~~~~~~~~~~
/builddir/sdb-2.0.1/bindings/vala/types/sdbinstance.c:5:10: fatal error: sdb.h: No such file or directory
    5 | #include "sdb.h"
      |          ^~~~~~~
compilation terminated.
error: cc exited with status 256
Compilation failed: 1 error(s), 0 warning(s)
make[1]: *** [Makefile:49: intermediate] Error 1
make[1]: Leaving directory '/builddir/sdb-2.0.1/bindings/vala/types'
make: *** [Makefile:123: install] Error 2

[trufae]

i cant reproduce, which are the exact commands you are typing?, maybe you have some custom CFLAGS that override the build ones?

[dora-meowmeow]

I'm using void linux's script. https://github.com/void-linux/void-packages/blob/master/srcpkgs/sdb/template here is the template used (when bumping the version number like so void-linux/void-packages@2d87ae3).

I do think the error happens because bindings expect to be built after base sdb is installed to the machine? Not sure just a theory. If so it might be a good idea to check if sdb is installed to include directory, if not point to the sdb.h inside the repo.

Either way using meson works fine.