Skip to content

Conversation

@jog1t
Copy link
Contributor

@jog1t jog1t commented Jan 2, 2026

TL;DR

Updated the offline runner status indicator to use a warning triangle icon with improved tooltip text.

What changed?

  • Imported faExclamationTriangle icon from Font Awesome
  • Changed the offline runner status icon from faSignalAlt to faExclamationTriangle
  • Updated the tooltip text from "Last ping X time ago" to "Offline (last seen X time ago)" for better clarity

How to test?

  1. Navigate to the runners table view
  2. Wait for a runner to go offline (or simulate an offline runner)
  3. Verify that the offline runner now displays a warning triangle icon instead of the signal icon
  4. Hover over the icon to confirm the tooltip now shows "Offline (last seen X time ago)"

Why make this change?

The warning triangle icon more clearly communicates an error state compared to the previous signal icon. The updated tooltip text also explicitly states that the runner is offline, making the status more immediately understandable to users.

@vercel
Copy link

vercel bot commented Jan 2, 2026

The latest updates on your projects. Learn more about Vercel for GitHub.

Project Deployment Review Updated (UTC)
rivet-inspector Ready Ready Preview, Comment Jan 3, 2026 0:08am
rivetkit-serverless Error Error Jan 3, 2026 0:08am
2 Skipped Deployments
Project Deployment Review Updated (UTC)
rivet-cloud Ignored Ignored Jan 3, 2026 0:08am
rivet-site Ignored Ignored Preview Jan 3, 2026 0:08am

Copy link
Contributor Author

jog1t commented Jan 2, 2026

Warning

This pull request is not mergeable via GitHub because a downstack PR is open. Once all requirements are satisfied, merge this PR as a stack on Graphite.
Learn more


How to use the Graphite Merge Queue

Add the label merge-queue to this PR to add it to the merge queue.

You must have a Graphite account in order to use the merge queue. Sign up using this link.

An organization admin has enabled the Graphite Merge Queue in this repository.

Please do not merge from GitHub as this will restart CI on PRs being processed by the merge queue.

This stack of pull requests is managed by Graphite. Learn more about stacking.

@claude
Copy link

claude bot commented Jan 2, 2026

Code Review - PR #3742

Overview

This PR improves the offline runner status indicator by changing the icon from a signal icon to a warning triangle and enhancing the tooltip text. The changes are straightforward and improve user experience.

✅ Positives

  • Better UX: The warning triangle icon (faExclamationTriangle) more clearly communicates an error/offline state compared to the signal icon
  • Clearer messaging: The tooltip text "Offline (last seen X time ago)" is more explicit than "Last ping X time ago"
  • Minimal scope: The changes are focused and don't introduce unnecessary modifications
  • Consistent styling: The icon uses the same red color (text-red-500) to maintain visual consistency

📝 Observations

Code Quality

  • The code follows existing patterns in the file
  • Import is correctly added alphabetically at the top
  • Formatting appears consistent with the codebase style

Minor Consideration
The comment on line 179 says "check if the last ping ts was higher than 15 seconds ago" - while this is accurate, it might be worth noting that this 15-second threshold determines when a runner is considered offline. This is more of a documentation observation than a code issue.

Testing

  • No automated tests found for this component (checked for runners-table.test.* and runners-table.spec.*)
  • Manual testing is straightforward per the PR description

🔍 No Issues Found

  • Security: No security concerns
  • Performance: No performance impact
  • Bugs: No potential bugs identified
  • Dependencies: Uses existing Font Awesome icon, no new dependencies

Recommendation

✅ Approve - This is a clean, focused improvement that enhances the user experience. The change is low-risk and clearly beneficial.


Review generated by Claude Code

@graphite-app
Copy link
Contributor

graphite-app bot commented Jan 2, 2026

Graphite Automations

"Test" took an action on this PR • (01/02/26)

1 assignee was added to this PR based on Kacper Wojciechowski's automation.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

2 participants