-
Notifications
You must be signed in to change notification settings - Fork 142
chore: fix type checks #3813
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
base: main
Are you sure you want to change the base?
chore: fix type checks #3813
Conversation
|
The latest updates on your projects. Learn more about Vercel for GitHub.
1 Skipped Deployment
|
|
🚅 Deployed to the rivet-pr-3813 environment in rivet-frontend
|
PR Review: Type Checking FixesOverviewThis PR addresses TypeScript type checking issues across the codebase, with a focus on adding explicit type annotations and fixing type mismatches. Positive Aspects
Concerns and Issues
RecommendationsHigh Priority: Remove commented code or fix errors, restore/document deleted example, fix stubbed implementations VerdictWhile core type safety improvements are valuable, this PR has significant issues with commented-out code and disabled functionality that should be addressed before merging. Status: Changes Requested |
More templates
@rivetkit/cloudflare-workers
@rivetkit/db
@rivetkit/framework-base
@rivetkit/next-js
@rivetkit/react
rivetkit
@rivetkit/sql-loader
@rivetkit/virtual-websocket
@rivetkit/engine-runner
@rivetkit/engine-runner-protocol
commit: |
No description provided.