From 4769f2b20c44552044be9c32c612faaaa33f706c Mon Sep 17 00:00:00 2001 From: TrooperCrypto Date: Wed, 21 May 2025 21:24:04 +0200 Subject: [PATCH] simplify stakeRPL As stakeRPL can only be called by the registered node ("onlyRegisteredNode(msg.sender)" modifier), there is no need to check if the caller is either of the withdrawal addresses. --- contracts/contract/node/RocketNodeStaking.sol | 3 +-- 1 file changed, 1 insertion(+), 2 deletions(-) diff --git a/contracts/contract/node/RocketNodeStaking.sol b/contracts/contract/node/RocketNodeStaking.sol index ee8d2e1a..bd261b26 100644 --- a/contracts/contract/node/RocketNodeStaking.sol +++ b/contracts/contract/node/RocketNodeStaking.sol @@ -176,8 +176,7 @@ contract RocketNodeStaking is RocketBase, RocketNodeStakingInterface { /// @notice Increases the calling node operator's megapool staked RPL by transferring RPL from msg.sender function stakeRPL(uint256 _amount) override external onlyRegisteredNode(msg.sender) { - // Check caller here and skip `stakeRPLFor` to avoid unnecessary check for rocketMerkleDistributorMainnet caller - require(callerAllowedFor(msg.sender), "Not allowed to stake for"); + // Caller is the node address. Skip `stakeRPLFor` to avoid unnecessary checks _stakeRPLFor(msg.sender, _amount); }