Skip to content

Indicate that we're only showing a subset of incorrect values #101

@gadenbuie

Description

@gadenbuie

In the following example, there are 5 unequal values in the column being checked.

pkgload::load_all()
#> ℹ Loading tblcheck

.result <- tibble::tibble(x = c(1:5, runif(5)))
.solution <- tibble::tibble(x = c(1:5, runif(5)))

But the values problem message only shows us 3 values and doesn't give any indication that there are more issues than these three.

tbl_grade_column("x")
#> <gradethis_graded: [Incorrect]
#>   I didn't expect your `x` column to include the values `0.2423`,
#>   `0.1420`, and `0.0605`.
#> >

We should either:

  1. Show the number of total errors, e.g.

    Your x column contains 5 unexpected values including 0.2423, 0.1420, and 0.0605.

  2. Give a hint that there are more errors, e.g.

    I didn't expect your x column to include the values 0.2423, 0.1420, and 0.0605 and 2 more.

  3. Both?

    Your x column contains 5 unexpected values including 0.2423, 0.1420, and 0.0605 and 2 more.

Metadata

Metadata

Assignees

Labels

No labels
No labels

Type

No type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions