From 0b1cd838b6b00acf8c3e846ecac8d260a6e794ca Mon Sep 17 00:00:00 2001 From: "Tj (bougyman) Vanderpoel" Date: Tue, 5 Aug 2025 10:28:09 -0500 Subject: [PATCH 1/2] fix: Stop sending code argument to respond_with_error, it does not accept it --- Gemfile.lock | 2 +- examples/echo_endpoint.rb | 3 ++- lib/leopard/message_wrapper.rb | 4 ++-- test/lib/message_wrapper.rb | 10 +++++----- 4 files changed, 10 insertions(+), 9 deletions(-) diff --git a/Gemfile.lock b/Gemfile.lock index fee305e..104afbd 100644 --- a/Gemfile.lock +++ b/Gemfile.lock @@ -1,7 +1,7 @@ PATH remote: . specs: - leopard (0.1.5) + leopard (0.1.6) concurrent-ruby (~> 1.1) dry-configurable (~> 1.3) dry-monads (~> 1.9) diff --git a/examples/echo_endpoint.rb b/examples/echo_endpoint.rb index 202b8ea..05e02f8 100755 --- a/examples/echo_endpoint.rb +++ b/examples/echo_endpoint.rb @@ -12,6 +12,7 @@ def initialize(a_var = 1) end endpoint(:echo) { |msg| Success(msg.data) } + endpoint(:echo_fail) { |msg| Failure({ failure: '*boom*', data: msg.data }.to_json) } end if __FILE__ == $PROGRAM_NAME @@ -22,6 +23,6 @@ def initialize(a_var = 1) version: '1.0.0', instance_args: [2], }, - instances: 4, + instances: 1, ) end diff --git a/lib/leopard/message_wrapper.rb b/lib/leopard/message_wrapper.rb index 732cdad..9594b11 100644 --- a/lib/leopard/message_wrapper.rb +++ b/lib/leopard/message_wrapper.rb @@ -33,8 +33,8 @@ def respond(payload) # @param code [Integer] The HTTP status code to use for the error response. # # @return [void] - def respond_with_error(err, code: 500) - raw.respond_with_error(err.to_s, code:) + def respond_with_error(err) + raw.respond_with_error(err.to_s) end private diff --git a/test/lib/message_wrapper.rb b/test/lib/message_wrapper.rb index 3ea550b..d4c85c9 100644 --- a/test/lib/message_wrapper.rb +++ b/test/lib/message_wrapper.rb @@ -15,8 +15,8 @@ def respond(payload) @responded_payload = payload end - def respond_with_error(err, code:) - @error_args = [err, code] + def respond_with_error(err) + @error_args = [err] end end @@ -57,15 +57,15 @@ def respond_with_error(err, code:) end it 'responds with error' do - wrapper.respond_with_error('fail', code: 404) + wrapper.respond_with_error('fail') - assert_equal ['fail', 404], msg.error_args + assert_equal ['fail'], msg.error_args end it 'coerces exception objects to strings when responding with error' do err = StandardError.new('broken') wrapper.respond_with_error(err) - assert_equal ['broken', 500], msg.error_args + assert_equal ['broken'], msg.error_args end end From e34e4486c5c71f126ae2a2b2f18fecbba37c40e2 Mon Sep 17 00:00:00 2001 From: "Tj (bougyman) Vanderpoel" Date: Tue, 5 Aug 2025 10:31:47 -0500 Subject: [PATCH 2/2] fix: Corrects the parameter documentation (Thanks Copilot) --- lib/leopard/message_wrapper.rb | 1 - 1 file changed, 1 deletion(-) diff --git a/lib/leopard/message_wrapper.rb b/lib/leopard/message_wrapper.rb index 9594b11..e1638ff 100644 --- a/lib/leopard/message_wrapper.rb +++ b/lib/leopard/message_wrapper.rb @@ -30,7 +30,6 @@ def respond(payload) end # @param err [String, Exception] The error message or exception to respond with. - # @param code [Integer] The HTTP status code to use for the error response. # # @return [void] def respond_with_error(err)