debian packaging

[adrelanos]

Since @rustybird does not wish to merge distribution specific stuff of distributions he does not use (#2 (comment)), I am only opening this as an issue, not as a pull request.

Work in progress:

EDIT:

• https://github.com/adrelanos/corridor
• https://github.com/rustybird/corridor/compare/master...adrelanos:master?expand=1

---

There is one issue that Debian will complain about.

W: corridor: executable-not-elf-or-script usr/sbin/corridor-load-config

That script if not executable does not belong there.

• Can we move it to a more appropriate location?
• Alternatively, can we make it executable and useful instead? When manually executed it could work as a config file sanity tester, i.e. just sourcing the config files in verbose -x mode and then exit with an "success" if that did not result in an error.

---

Would you like to ship a man folder with manuals in ruby-ronn format in rustybird/corridor master?

• https://github.com/Whonix/tor-ctrl/tree/master/man
• https://github.com/Whonix/tor-ctrl/blob/master/man/tor-ctrl.8.ronn

I guess I could contribute the original, basic man pages.

(The Debian packaging that I am using would convert them during package build to proper man pages compatible with gnu man. Much better than learning and writing the roff format.)

That would help Debian lintian (package checker) no longer complain about missing man pages. The man pages shipped at upstream rustybird/corridor seems more useful than in downstream adrelanos/corridor.

[rustybird]

Alternatively, can we make it executable and useful instead? When manually executed it could work as a config file sanity tester, i.e. just sourcing the config files in verbose -x mode and then exit with an "success" if that did not result in an error.

Sounds good, done.

[adrelanos]

What about the man pages? I think I could also write them in markdown, then convert them roff and eventually send a pull request here.

They are looking quite okay, I think. You can see one created that way in action in Whonix. Example:

man tor-ctrl

[rustybird]

What about the man pages?

What do you think about a combined manpage (i.e. man corridor, symlinked to the individual command names)? It could show how everything fits together, and would probably avoid some redundancy.

I think I could also write them in markdown, then convert them roff and eventually send a pull request here.

Either way would be fine, I'd check in both your source and the generated output anyway. Like it's often done for configure.ac and configure.

They are looking quite okay, I think.

Yeah, even the generated roff code doesn't look terrible. I like it!

[adrelanos]

I don't know if a combined man page would be acceptable by Debian policy or otherwise. I will ask.

---

Debian request for packaging feature request:
RFP: corridor - a Tor traffic whitelisting gateway

• http://bugs.debian.org/cgi-bin/bugreport.cgi?bug=829740
• http://lists.alioth.debian.org/pipermail/pkg-privacy-maintainers/Week-of-Mon-20160704/000814.html

---

Perhaps for getting this into official Debian, I would have to become upstream. I'd be maintaining a Debian friendly fork of corridor. This is because for getting this packages, I patched the makefile and added an additional dependency, genmkfile. Let's see what pkg-privacy-maintainers say and how supportive they are.

[adrelanos]

I am not wiser about the combined manpage yet. Will ask in another place.

What however would work would be having just one corridor binary in /usr/sbin/corridor which would just be a stub calling the others scripts from /usr/share/corridor/{forwarding-init,...}. Then a combined manpage would certainly be possible. Whether this is a good idea is another question.

[adrelanos]

W: corridor: executable-not-elf-or-script usr/sbin/corridor-load-config

Fixed:

• https://lists.debian.org/debian-mentors/2016/07/msg00228.html
• adrelanos@90663fe

I am not wiser about the combined manpage yet. Will ask in another place.

Asked:
https://lists.debian.org/debian-mentors/2016/07/threads.html

[adrelanos]

A combined manpage is permissible.