Support for multiple connections

[technomancy]

It seems like right now monroe only supports connecting to a single nrepl instance at a time.

Are you interested in adding support for more than one active *monroe* buffer, or is it better to use separate Emacs instances for that?

[sanel]

I was planning to add it (made a few attempts), just didn't have enough time to complete it. However, if you are able to do it, keeping the code simple, I'll be happy to accept the patch :)

[technomancy]

Good to know; thanks. No promises, but I might take a shot at this at some point.

[bbuccianti]

I'm thinking of making an attempt too. Maybe we can discuss a little about how to do it?

[sanel]

Feel free @bbuccianti :) Maybe check inferior-lisp mode (inf-lisp.el in Emacs) for multiple processes support.

[sogaiu]

@bbuccianti

For reference, if you want to see an existing attempt for a socket repl-based thing with multiple connections, I've had some luck w/:

• https://github.com/sogaiu/acrepl/blob/arcadia-and-reconnect/acrepl-connect.el
• https://github.com/sogaiu/acrepl/blob/arcadia-and-reconnect/acrepl.el

It's been working pretty well for me so far.

I started with sesman, but decided it was much more than I needed.

[bbuccianti]

@sanel @technomancy @sogaiu

Can you help me test this?

https://github.com/bbuccianti/monroe/

I'm sure there is a lot of ways to improve it, please help me!

[sogaiu]

Do you mean the multiple-connections branch?

https://github.com/bbuccianti/monroe/tree/multiple-connections

[bbuccianti]

This is the correct commit:

bbuccianti@38a1488

[sogaiu]

Had success interacting with 2 separate processes from within a single emacs instance.

Opened two files -- each one from a different project -- ran M-x monroe in each and tried M-x monroe-eval-region. Seems to work 👍

IIUC, there is at most one connection per project and at most one process per project. Is that correct?

[bbuccianti]

Yes, it's using the project folder as a pointer concatenating it with monroe and monroe-conn buffers.

I've created a pull request #33

[sanel]

Thanks @bbuccianti for your work and @sogaiu for fast response!

Is #33 will add support for multiple connections? Title of PR confuses me :)

Also, does it handle reading .nrepl-port from project tree?

[bbuccianti]

It still uses monroe-locate-port-file.

The only change is that instead of naming the buffers *monroe* and *monroe-conn* I conj the project folder to it. Then, when you try to send code to the nrepl it searches for the correct buffers using the project folder.

[bbuccianti]

@sanel I just improved the title of the PR

[sanel]

Thanks! Here are few issues I found (my Emacs is 26.3). After first expression is entered (in single or multiple REPL connections), prompt is not shown any more. Next issue is connecting to REPLs outside of working directories. For example, you run REPL at `localhost:7888` in project `foo`, then in external terminal run REPL in project `baz` at `localhost:7889`, but keep Emacs in project `foo`, it will connect to `foo` for both REPL and inputs and outputs will be shared. The same applies if you connect Emacs to any multiple projects without entering to project folders. Since you are calculating process name from working directory, I'd suggest to use combination of host+port instead, because they have to be unique on given system. Also, I'd suggest to pop out exising monroe connection REPL if user attempt to connect to that session again. This will prevent multiple REPLs that will echo inputs and outputs between each other.

[bbuccianti]

I can't reproduce the issue with prompt. Maybe I'm evaluating trivial things, but seems to work fine for me.

bbuccianti@05b37d9

Now it's using the host:port combination to name buffers and also call (monroe-disconnect) before trying to attempt another connection.

Let me know!