-
Notifications
You must be signed in to change notification settings - Fork 34
Description
Describe the bug
During development of #4076, I found that many of the existing Studies in the Sequencescape database do not conform to the new validation rules.
Because of this, I deployed the new server-side validation for that story 'feature flagged off'. This story is to track the resolution of this. Ideally, we can 'fix' all the existing studies, so that they pass the new validation, and then remove the feature flag.
There is an ongoing conversation via email between Katy, Liz C and Governance as to whether the validation rules are correct, and whether we can 'fix' those studies.
Additional context
See query to find records that fail the validation here:
#4076 (comment)
Table that shows the expected relationships between fields, which the new validation would enforce:
| Data release strategy | Data release timing |
|---|---|
| Managed or Open | Standard, Immediate or Delayed |
| Not applicable | Never |
To remove the feature flag, merge the following pull request: #4086
This will be the first time the server-side validation is enabled, so consider doing some extra testing of it.
Solution: prepare a spreadsheet broken down by faculty. The strategy for each study needs to match the data release timing
We still need to do it for inactive studies? Could we change validation so that it doesn't validate if it is inactive? Maybe they haven't started yet? What if they have samples that have an accession number?