Y26-021 - [BUG] SS Accessioning - As a TL, I would like to remove any accessioning check at work completion (aka charge & pass) so that metadata problems do not stop lab processing.

[andrewsparkes]

Y26-021 - [BUG] SS Accessioning - As a TL, I would like to remove any accessioning check at work completion (aka charge & pass) so that metadata problems do not stop lab processing.

Describe the bug
ANOSPP is set as a Delayed publication study, and yet at work completion at the end of library prep checks are made to ensure all samples have been accessioned. This should not be the case, accessioning status should not block such samples from proceeding.

To Reproduce
Steps to reproduce the behaviour:

1. Run the ANOSPP pipeline (or any with samples under a delayed study) with un-accessioned samples (NB. in environment where accessioning is switched on)
2. Click on button 'charge and pass'
3. See error

Expected behaviour
Work completion should not be checking accessioning status.

Additional Context
Accessioning status and the ability to re/accession all samples in a study is now available under studies information page e.g. /studies/8306/information

Disabling the charge and pass accessioning check is linked to the disable_accession_check configatron variable. Essentially, anything that calls this, including the Submission::AccessionBehaviour module itself, can go.
Likewise disable_accession_check should also be removed from the deployment project.

There's a nice visual of how this currently works in #5319.

[StephenHulme]

Work completion for Delayed studies should not be checking accessioning status.

I believe this is a criteria that wasn't recorded in the original delayed release story? If you're able to find that story it would be most helpful to better understand what is happening and why?

[TWJW-SANGER]

I have changed the story following today's meeting.

[andrewsparkes]

What's happening here is workcompletion closes off the library prep submission and automatically attempts to start the sequencing submission. There's a validation on generating the Orders with SequencingRequests requiring accessioning to have been done (if the study requires accessioning). This check blocks you if accessioning has not been done on all the samples.
This same restriction is triggered for any direct submission using a SequencingRequest, i.e. when SSRs make a direct sequencing submission on pre-made libraries.
So this change impacts both workcompletions triggered by the Limber users completing library prep where it is automatically trying to start the sequencing submission, and SSRs making direct sequencing submissions in Sequencescape.