Skip to content

Remove dependency on play-guice #37

@berryware

Description

@berryware

scaldi-play currently requires that the guice module be loaded to use it. This never felt right to me. It appears to be required because of a reference to com.google.inject.CreationException. In looking at the catch block, there is no need for this reference.

I propose that the catch block in ScaldiBuilder.scala be changed to

    } catch {
      case p: PlayException => throw p
      case t: Throwable => t.getCause match {
        case pe: PlayException => throw pe
        case _ => throw t
      }
    }

I will submit a pull request for the above

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions