-
-
Notifications
You must be signed in to change notification settings - Fork 146
Open
Description
Hey Simon, all but the first hash per tool has a leading newline here:
Line 38 in 8152f0b
| commit_hash = raw_commit[:first_pipe] |
The colophon page thus ends up having the HTML “broken” in the commit hash URLs because of the leading newlines, although browsers don't seem to be fazed by it. I did have an issue with these newlines in the middle of URLs, though, and ended up fixing it with a plain call to .strip():
commit_hash = raw_commit[:first_pipe].strip()Thought you might like to know since these extra newlines might bite you later down the road.
Metadata
Metadata
Assignees
Labels
No labels