Skip to content

Hashes in gathered links may contain leading newlines #172

@rodrigogiraoserrao

Description

@rodrigogiraoserrao

Hey Simon, all but the first hash per tool has a leading newline here:

commit_hash = raw_commit[:first_pipe]

The colophon page thus ends up having the HTML “broken” in the commit hash URLs because of the leading newlines, although browsers don't seem to be fazed by it. I did have an issue with these newlines in the middle of URLs, though, and ended up fixing it with a plain call to .strip():

commit_hash = raw_commit[:first_pipe].strip()

Thought you might like to know since these extra newlines might bite you later down the road.

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions