-
-
Notifications
You must be signed in to change notification settings - Fork 94
Open
Description
RMS =
example: analysis_spot() in geolens.py
spot_rms = ((ray_xy_norm**2).sum(-1).sqrt() * ray.is_valid).sum(-1) / (
ray.is_valid.sum(-1) + EPSILON
)
I think should be
spot_rms = torch.sqrt(
((ray_xy_norm**2).sum(-1) * ray.is_valid).sum(-1) / (ray.is_valid.sum(-1) + EPSILON)
)
other places this occur include geolens_pkg/optim.py in autolens, and 2_autolens_rms.py and Autolens_rms tutorial notebook
Pls let me know if you agree and I can submit a PR fixing it. I think the RMS calculation for loss and training is still correct.
Reactions are currently unavailable
Metadata
Metadata
Assignees
Labels
No labels