output did not contain correct version

[mrmodolo]

Hi!

The latest update no longer allows updating binaries!

I found that binaries in '~/.loki-shell/bin/' no longer show version as expected:

for f in .loki-shell/bin/*; do $f --version; done;
logcli, version  (branch: , revision: )
  build user:       
  build date:       
  go version:       go1.16.2
  platform:         linux/amd64
loki, version  (branch: , revision: )
  build user:       
  build date:       
  go version:       go1.16.2
  platform:         linux/amd64
promtail, version  (branch: , revision: )
  build user:       
  build date:       
  go version:       go1.16.2
  platform:         linux/amd64

I had to change the check_binary function in the install file to ignore the version and be able to install the binaries.

Regards,
Marcelo Módolo

[mrmodolo]

Hi!

I found that the problem is with the output of binaries with the '--version' option in the 2.3.0 release

with 2.2.1
./loki-linux-amd64 --version
loki, version 2.2.1 (branch: HEAD, revision: babea82e)
  build user:       root@e2d295b84e26
  build date:       2021-04-06T00:52:41Z
  go version:       go1.15.3
  platform:         linux/amd64

with 2.3.0  
./loki-linux-amd64 --version
loki, version  (branch: , revision: )
  build user:       
  build date:       
  go version:       go1.16.2
  platform:         linux/amd64  

Regards,

Marcelo Módolo

[slim-bean]

Ahh, good cactch @mrmodolo and thanks for reporting. I believe we fixed this in Loki 2.4.0, gonna do some updating myself today and I'll make sure.