Skip to content

Display CommitVerificationResults on Admin approval page #520

@frozenfrank

Description

@frozenfrank

Overview

Now that the data is available in the Submission object, we want to display it to TAs (admins) in a friendly format.

Details

See the new CommitsByDay documentation (current, eventual) for additional information about the errors surfaced by the system.

When presenting this information, it is recommended to do the following:

  • Represent all error categories, potentially excluding a limited blacklist. This will give future errors the best chance at correct representation.
  • Combine the commit hash with the repoUrl to create a direct link to the commit in a new tab.
  • Focus on each group of errors:
    • Show each group of raised errors/warnings
    • List each commit that triggered it
  • AND/OR Focus on the linearized commit history
    • Iterate over linearizedCommits
    • Show each commit with key information in a dense format:
      • Number of line changes
      • All errors/warnings associated with the commit hash

An initial attempt at this change was tried in #460. The next solution may want to be review that PR for a taste of an approach that would have worked, if continued.

Metadata

Metadata

Assignees

Labels

enhancementNew feature or request

Type

Projects

No projects

Milestone

No milestone

Relationships

None yet

Development

No branches or pull requests

Issue actions