You signed in with another tab or window. Reload to refresh your session.You signed out in another tab or window. Reload to refresh your session.You switched accounts on another tab or window. Reload to refresh your session.Dismiss alert
Copy file name to clipboardExpand all lines: plans/ISSUE_WARNING_resource_was_not_closed.md
+4Lines changed: 4 additions & 0 deletions
Display the source diff
Display the rich diff
Original file line number
Diff line number
Diff line change
@@ -58,3 +58,7 @@ The warning was not tied to the `cloudsync_changes` view itself, but to **nested
58
58
- the server (PG17) reported unclosed relation resources at statement end.
59
59
60
60
By switching to `cloudsync_changes_apply(...)` and tightening SPI tuptable cleanup, we removed the warning from the payload-apply path while leaving manual insert behavior unchanged.
61
+
62
+
## Next TODO
63
+
- Add SPI instrumentation (DEBUG1 logs before/after SPI_execute* and after SPI_freetuptable/SPI_finish) along the payload-apply → view-insert → trigger path, then rerun the instrumented smoke test to pinpoint exactly where the warning is emitted.
64
+
- Note: We inspected the payload-apply → INSERT INTO cloudsync_changes → trigger call chain and did not find any missing SPI_freetuptable() or SPI_finish() calls in that path.
0 commit comments