Skip to content

fix(field-access-report): reference policy default in denial reason for root fields without explicit rule #114

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
ddebrunner merged 2 commits into from
Jul 15, 2025
Merged

fix(field-access-report): reference policy default in denial reason for root fields without explicit rule #114

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
f3597cd
fix(field-access-report): reference policy default in denial reason f…
carloseberhardt Jul 15, 2025
a4e6f40
added modified missing files
carloseberhardt Jul 15, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
8 changes: 6 additions & 2 deletions src/services/fieldAccessReport.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -174,8 +174,12 @@ export async function generateFieldAccessReportData(
} else {
// No rule found, deny by default
access = "denied";
condition = "false";
reason = `No rule found for field ${field.name} in policy for root type ${typeName}: denied by default`;
condition = policy && policy.policyDefault ? policy.policyDefault.condition : "false";
if (policy && policy.policyDefault) {
reason = `Policy default: denied (condition: ${policy.policyDefault.condition})`;
} else {
reason = `No rule found for field ${field.name} in policy for root type ${typeName}: denied by default`;
}
}
}
}
Expand Down
Loading