-
Notifications
You must be signed in to change notification settings - Fork 42
Open
Labels
enhancementNew feature or requestNew feature or requesthelp wantedExtra attention is neededExtra attention is needed
Description
The lack of feedback during Collection.upsert and Collection.create_index is a bad DX.
It would be great to get some progress bars but I haven't been able to get them working properly in notebooks and shell environments.
If anyone has experience adding them this would be a great community contribution
upsert
Line 108 in 87ed2d3
| for chunk in flu(vectors).chunk(chunk_size): |
but it can't always assume that
vectors is sized. Maybe a runtime check to see if *vectors* has a known length and providing it to the progress bar if known would be best
create_index
Lines 346 to 350 in 87ed2d3
| stmt = postgresql.insert(clone_table).from_select( | |
| self.table.c, select(self.table) | |
| ) | |
| stmt = stmt.on_conflict_do_nothing() | |
| sess.execute(stmt) |
this one is a little more involved as it'll have to introduce client side keyset pagination on the id primary key to get feedback to python
Metadata
Metadata
Assignees
Labels
enhancementNew feature or requestNew feature or requesthelp wantedExtra attention is neededExtra attention is needed