Do not check links in content elements within hidden gridelements or container (or other container elements)

[sypets]

Is your feature request related to a problem? Please describe.

• Broken links are displayed even though they are in content elements in hidden container elements (or gridelemens).
• Also, links in content elements are checked if the content element is in an invalid colpos (this is detected by TYPO3 and "Unused elements detected on this page" displayed in page mode in BE)
• if element is in connected mode and element in original language is disabled, this will also not be displayed in FE
• if pages.l18n_cfg has "Hide default language of page" set, elements in default lang should not be checked (this is already handled but we should check and make sure there are tests)

In any case, links should not be checked if they are not visible in the rendered Frontend page (unless "checkhidden") is enabled.

Describe the solution you'd like

Unless the page TSconfig option mod.brofix.checkhidden is on, links in hidden elements should not be checked. This includes elements in containers such as via EXT:container or EXT:gridelements.

How to implement

... tbd

• TYPO3 BackendLayoutRenderer::drawContent() displays the message with title staleUnusedElementsWarningTitle, it calls ContentFetcher::getUnusedRecords() which uses the TYPO3 event IsContentUsedOnPageLayoutEvent to check if content is used. The EXT:container extension listens to this event. BUT, the element is added as not visible if in wrong colpos (for example), but not if container is hidden!
• Also, if elements are nested, this will currently be insufficient via the event

[sorenmalling]

@sypets We just had this exact topic raised :)

We thought about a event inside the LinkAnalyzer class, more of a "Pre-processing of record" where it could be excluded.

So a EvetListener like this(-ish)

$connection = ConnectionPool::getConnectionForTable('tt_content');
$parent = $connection->select('hidden')->from('tt_content')->where('uid', $record['parentid']);

if ( (bool) $parent['hidden']) {
  $this->exclude = true;
}

[sypets]

@sorenmalling Thanks for reminding me. This is actually quite annoying for editors.

There is an event listener in b13/container ContentUsedOnPage which listens to a core event TYPO3\CMS\Backend\View\Event\IsContentUsedOnPageLayoutEvent

It would be nice if we can reuse existing events / event listeners.

This is just off the top of my hat. Will need to look into it (and will take a while since holiday coming up 😄)

[sorenmalling]

@sypets In this linkanalyzing-phase, I see a need for a event such as "BeforeAnalyzingLinkEvent".

Given the record a link is found in, it's possible to do custom check and even do a generic check for extensions like EXT:container. Pseudo idea code

public function __invoke(BeforeAnalyzingLinkEvent $event)
{
  $record = $event->getRecord();
  if ($record['tx_container_parent'] !== 0)
  {
    $container = BackendUtility::getRecord('tt_content', (int) $record['tx_container_parent']);
    if ((bool) $container['hidden']) {
      $event->skip(); #Set a event boolean to true, skipping this link for checking
    }
  } 
}

[sorenmalling]

The class BeforeAnalyzingLinkEvent looking something like

final class BeforeAnalyzingLinkEvent
{
  protected bool $skip = false;

  protected string $tableName;
  protected array $record;

  public function skip(): void
  {
    $this->skip = true;
  }
}