Unit tests for ranged GTID updates.

Author: proton-lisandro-pin

include/proxysql_gtid.h

@@ -29,6 +29,7 @@ class Gtid_Interval {
 		const int cmp(const Gtid_Interval& other);
 		const bool operator<(const Gtid_Interval& other);
 		const bool operator==(const Gtid_Interval& other);
+		const bool operator!=(const Gtid_Interval& other);
 };
 typedef Gtid_Interval gtid_interval_t;
 

lib/proxysql_gtid.cpp

@@ -121,3 +121,7 @@ const bool Gtid_Interval::operator<(const Gtid_Interval& other) {
 const bool Gtid_Interval::operator==(const Gtid_Interval& other) {
 	return cmp(other) == 0;
 }
+
+const bool Gtid_Interval::operator!=(const Gtid_Interval& other) {
+	return cmp(other) != 0;
+}

test/tap/tests/Makefile

@@ -93,11 +93,7 @@ CUSTOMARGS += -Wl,-Bdynamic -lcpp_dotenv -lcurl -lssl -lcrypto -lre2 -lpthread -
 .PHONY: all
 all: tests
 
-debug: OPT := $(STDCPP) -O0 -DDEBUG -ggdb -Wl,--no-as-needed -Wl,-rpath,$(TAP_LDIR) $(WGCOV) $(WASAN) -DGITVERSION=\"$(GIT_VERSION)\"
-debug: tests
-
-tests: CUSTOMARGS += $(OPT)
-tests: tests-cpp \
+tap-tests: tests-cpp \
 	tests-php \
 	tests-py \
 	tests-sh \
@@ -125,6 +121,15 @@ tests: tests-cpp \
 	fast_forward_switch_replication_deprecate_eof_libmysql-t \
 	reg_test_mariadb_stmt_store_result_libmysql-t \
 	reg_test_mariadb_stmt_store_result_async-t
+
+unit-tests: \
+	unit-proxysql_gtid-t
+
+debug: OPT := $(STDCPP) -O0 -DDEBUG -ggdb -Wl,--no-as-needed -Wl,-rpath,$(TAP_LDIR) $(WGCOV) $(WASAN) -DGITVERSION=\"$(GIT_VERSION)\"
+debug: tests
+
+tests: CUSTOMARGS += $(OPT)
+tests: tap-tests unit-tests
 tests:
 	@echo "Removing empty .gcno files ..."
 	find -L . -type f -name '*.gcno' -empty -ls -delete

test/tap/tests/unit-proxysql_gtid-t.cpp

@@ -0,0 +1,114 @@
+#include <stdlib.h>
+
+#include "tap.h"
+#include "unit_test.h"
+#include "proxysql_gtid.h"
+
+using std::string;
+
+int testGtidIntervalFromString_Count() {
+    return 2;
+}
+void testGtidIntervalFromString() {
+	ok(gtid_interval_t("123-456") == gtid_interval_t(123, 456), "GTID interval from range string");
+	ok(gtid_interval_t("111") == gtid_interval_t(111, 111), "GTID interval from single GTID string");
+}
+
+int testGtidIntervalContains_Count() {
+	return 8;
+}
+void testGtidIntervalContains() {
+	auto iv = gtid_interval_t(123, 456);
+
+	ok(iv.contains(123), "GTID interval contains start");
+	ok(iv.contains(456), "GTID interval contains end");
+	ok(iv.contains(300), "GTID interval contains middle");
+	ok(!iv.contains(100), "GTID interval doesn't contain before start");
+	ok(!iv.contains(500), "GTID interval doesn't contain past end");
+	ok(!iv.contains(gtid_interval_t(100, 300)), "GTID interval doesn't contain range before start");
+	ok(!iv.contains(gtid_interval_t(300, 500)), "GTID interval doesn't contain range past end");
+	ok(iv.contains(gtid_interval_t(150, 310)), "GTID interval contains range");
+}
+
+int testGtidIntervalAppend_Count() {
+	return 7;
+}
+void testGtidIntervalAppend() {
+	auto iv = gtid_interval_t(123, 456);
+
+	ok(!iv.append(gtid_interval_t(90, 100)), "cannot append before range start");
+	ok(!iv.append(gtid_interval_t(100, 200)), "cannot append at start");
+	ok(!iv.append(gtid_interval_t(500, 600)), "cannot append past end");
+	ok(iv.append(gtid_interval_t(457, 490)), "append");
+	ok(iv.to_string() == "123-490", "append result");
+
+	iv = gtid_interval_t(123, 456);
+	ok(iv.append(gtid_interval_t(200, 600)), "append with overlap");
+	ok(iv.to_string() == "123-600", "append with overlap result");
+}
+
+int testGtidIntervalMerge_Count() {
+	return 14;
+}
+void testGtidIntervalMerge() {
+	auto iv = gtid_interval_t(123, 456);
+	ok(!iv.merge(gtid_interval_t(90, 100)), "cannot merge before range start");
+	ok(!iv.merge(gtid_interval_t(500, 600)), "cannot merge past range end");
+	ok(iv.merge(gtid_interval_t(90, 200)), "merge at start");
+	auto want = gtid_interval_t(90, 456);
+	ok(iv == want, "merge at start result");
+
+	iv = gtid_interval_t(123, 456);
+	ok(iv.merge(gtid_interval_t(300, 500)), "merge at end");
+	want = gtid_interval_t(123, 500);
+	ok(iv == want, "merge at end result");
+
+	iv = gtid_interval_t(123, 456);
+	ok(iv.merge(gtid_interval_t(200, 300)), "merge at middle");
+	want = gtid_interval_t(123, 456);
+	ok(iv == want, "merge at middle result");
+
+	iv = gtid_interval_t(123, 456);
+	ok(iv.merge(gtid_interval_t(100, 500)), "merge overlap");
+	want = gtid_interval_t(100, 500);
+	ok(iv == want, "merge overlap result");
+
+	iv = gtid_interval_t(123, 456);
+	ok(iv.merge(gtid_interval_t(100, 122)), "merge append at start");
+	want = gtid_interval_t(100, 456);
+	ok(iv == want, "merge append at start result");
+
+	iv = gtid_interval_t(123, 456);
+	want = gtid_interval_t(123, 600);
+	ok(iv.merge(gtid_interval_t(457, 600)), "merge append at end");
+	ok(iv == want, "merge append at end result");
+}
+
+std::function<int(void)> testFunctionCounts[] = {
+	testGtidIntervalFromString_Count,
+	testGtidIntervalContains_Count,
+	testGtidIntervalAppend_Count,
+	testGtidIntervalMerge_Count,
+};
+std::function<void(void)> testFunctions[] = {
+	testGtidIntervalFromString,
+	testGtidIntervalContains,
+	testGtidIntervalAppend,
+	testGtidIntervalMerge,
+};
+
+int main(int argc, char** argv) {
+	// Set up unit tests...
+	int n = 0;
+	for (auto f : testFunctionCounts) {
+		n += f();
+	}
+	plan(n);
+	
+	// ...and run them.
+	for (auto f : testFunctions) {
+		f();
+	}
+
+	return exit_status();
+}