Skip to content

Improve nomenclature of error-handling functions #94

@dblohm7

Description

@dblohm7
          It appears that the returned error is unused. And it is in fact unused, but `newError` also logs it, and panics if panicking on error is enabled. So, I think it works correctly and as intended and is just not super clear from the context.

This is probably the second instance where we use newError this way. Maybe we should add a reportError or logError function that calls newError under the hood but makes the intended behavior clearer?

Originally posted by @nickkhyl in #89 (comment)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Type

    No type

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions