Skip to content

Commit 75bf696

Browse files
committed
Rename Reviewer role to Collaborator
Our GitHub teams use the term `collaborator` to maintain the list of `reviewers` which can be confusing. This commit renames the Reviewer role to Collaborator to match the way our team setup works. Signed-off-by: Dibyo Mukherjee <dibyo@google.com>
1 parent 9c74cbf commit 75bf696

File tree

1 file changed

+18
-16
lines changed

1 file changed

+18
-16
lines changed

process/contributor-ladder.md

Lines changed: 18 additions & 16 deletions
Original file line numberDiff line numberDiff line change
@@ -17,7 +17,7 @@ things. "Responsibilities" are things that contributor is expected to do.
1717
- [Community Participant](#community-participant)
1818
- [Contributor](#contributor)
1919
- [Organization Member](#organization-member)
20-
- [Reviewer](#Reviewer)
20+
- [Collaborator](#collaborator)
2121
- [Maintainer](#maintainer)
2222
- [Governance Committee Member](#governance-committee-member)
2323

@@ -97,21 +97,23 @@ The process for a Contributor to become an Organization Member is as follows:
9797
[org.yaml](https://github.com/tektoncd/community/blob/main/org/org.yaml),
9898
adding your GitHub username to `orgs.tektoncd.members`.
9999

100-
## Reviewer
100+
## Collaborator
101101

102-
Description: A Reviewer has responsibility for specific code, documentation,
102+
**Note:** This role used to be called `Reviewer` in the past.
103+
104+
Description: A Collaborator has responsibility for specific code, documentation,
103105
test, or other project areas. They are collectively responsible, with other
104-
Reviewers, for reviewing all changes to those areas and indicating whether those
106+
Collaborators, for reviewing all changes to those areas and indicating whether those
105107
changes are ready to merge. They have a track record of contribution and review
106108
in the project.
107109

108-
Reviewers are responsible for a "specific area." This can be a specific code
110+
Collaborators can be responsible for a "specific area." This can be a specific code
109111
directory, driver, chapter of the docs, test job, event, or other
110112
clearly-defined project component that is smaller than an entire repository or
111113
subproject. Most often it is one or a set of directories in one or more Git
112114
repositories. The "specific area" below refers to this area of responsibility.
113115

114-
Reviewers have all the rights and responsibilities of an
116+
Collaborators have all the rights and responsibilities of an
115117
[Organization Member](#organization-member), plus:
116118

117119
- Responsibilities include:
@@ -135,11 +137,11 @@ Reviewers have all the rights and responsibilities of an
135137
- May [`/lgtm`](#prow-commands) pull requests.
136138
- Can be allowed to [`/approve`](#prow-commands) pull requests in specific
137139
sub-directories of a project (by maintainer discretion)
138-
- Can recommend and review other contributors to become Reviewers
140+
- Can recommend and review other contributors to become Collaborators
139141

140142
To facilitate productivity, small repositories, or repositories that do not
141143
contain production code may decide to use simpler requirements. To become a
142-
Reviewer of one of these repositories, you must either:
144+
Collaborator of one of these repositories, you must either:
143145

144146
- Be an OWNER on any other repository in the Tekton project, and ask an existing
145147
OWNER to add you.
@@ -154,22 +156,22 @@ Repositories currently using this simpler mechanism are:
154156
- tektoncd/website
155157
- tektoncd/experimental
156158

157-
The process of becoming a Reviewer is:
159+
The process of becoming a Collaborator is:
158160

159161
1. The contributor is nominated by opening a PR against the appropriate
160162
project/directory
161163
[OWNERS file](https://www.kubernetes.dev/docs/guide/owners/), adding their
162164
GitHub username to the `reviewers` list (or corresponding
163165
[OWNERS alias](https://www.kubernetes.dev/docs/guide/owners/#owners_aliases)).
164-
2. At least two Reviewers/[Maintainers](#maintainer) of the team that owns that
166+
2. At least two Collaborator/[Maintainers](#maintainer) of the team that owns that
165167
repository or directory approve the PR.
166-
3. Update [org.yaml](./org/org.yaml) to add the new Reviewer to the
168+
3. Update [org.yaml](./org/org.yaml) to add the new Collaborator to the
167169
corresponding
168170
[GitHub team(s)](https://docs.github.com/en/organizations/organizing-members-into-teams/about-teams).
169171

170-
- Each project has a `<repo>.Reviewers` entry in `org.yaml`, where `<repo>` is
172+
- Each project has a `<repo>.collaborators` entry in `org.yaml`, where `<repo>` is
171173
the name of the GitHub repository. The only exception is `pipeline` whose
172-
maintainer team is name `core.Reviewers`.
174+
maintainer team is name `core.collaborators`.
173175

174176
## Maintainer
175177

@@ -179,11 +181,11 @@ area of a project, and are expected to participate in making decisions about the
179181
strategy and priorities of the project.
180182

181183
A Maintainer must meet the responsibilities and requirements of a
182-
[Reviewer](#Reviewer), plus:
184+
[Collaborator](#Collaborator), plus:
183185

184186
- Responsibilities include:
185187
- Reviewing PRs that involve multiple parts of the project
186-
- Mentoring new [Contributors](#contributor) and [Reviewers](#Reviewer)
188+
- Mentoring new [Contributors](#contributor) and [Collaborators](#Collaborator)
187189
- Writing PRs that involve many parts of the project (e.g. refactoring)
188190
- Participating in Tekton maintainer activities (build captain, WG lead)
189191
- Determining strategy and policy for the project
@@ -226,7 +228,7 @@ Repositories currently using this simpler mechanism are:
226228

227229
Process of becoming an Maintainer:
228230

229-
1. Any current Maintainer may nominate a current [Reviewer](#Reviewer) to become
231+
1. Any current Maintainer may nominate a current [Collaborator](#Collaborator) to become
230232
a new Maintainer, by opening a PR against the appropriate project/directory
231233
[OWNERS file](https://www.kubernetes.dev/docs/guide/owners/), adding their
232234
GitHub username to the `approvers` list (or corresponding

0 commit comments

Comments
 (0)