refactor: additional test case

Author: MohammadAlhallaq

packages/validation/src/Rules/Closure.php …kages/validation/src/Rules/Predicate.phppackages/validation/src/Rules/Closure.php renamed to packages/validation/src/Rules/Predicate.php packages/validation/src/Rules/Closure.php renamed to packages/validation/src/Rules/Predicate.php

@@ -5,6 +5,7 @@
 namespace Tempest\Validation\Rules;
 
 use Attribute;
+use Closure;
 use InvalidArgumentException;
 use ReflectionFunction;
 use Tempest\Validation\Rule;
@@ -15,12 +16,12 @@
  * The closure receives the value and must return true if it is valid, false otherwise.
  */
 #[Attribute(Attribute::TARGET_PROPERTY | Attribute::IS_REPEATABLE)]
-final readonly class Closure implements Rule
+final readonly class Predicate implements Rule
 {
-    private \Closure $callback;
+    private Closure $callback;
 
     public function __construct(
-        \Closure $callback,
+        Closure $callback,
     ) {
         $this->callback = $callback;
 

packages/validation/tests/Fixtures/ObjectWithPredicateValidation.php

@@ -0,0 +1,15 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tempest\Validation\Tests\Fixtures;
+
+use Tempest\Validation\Rules\Predicate;
+
+final class ObjectWithPredicateValidation
+{
+    #[Predicate(static function (string $value): bool {
+        return str_contains((string) $value, '@');
+    })]
+    public string $prop;
+}

packages/validation/tests/Rules/ClosureTest.php

@@ -0,0 +1,59 @@
+<?php
+
+declare(strict_types=1);
+
+namespace Tempest\Validation\Tests\Rules;
+
+use PHPUnit\Framework\TestCase;
+use ReflectionProperty;
+use Tempest\Validation\Rules\Predicate;
+use Tempest\Validation\Tests\Fixtures\ObjectWithPredicateValidation;
+
+/**
+ * @internal
+ */
+final class PredicateTest extends TestCase
+{
+    public function test_predicate_attribute_on_property_is_applied()
+    {
+        $reflection = new ReflectionProperty(ObjectWithPredicateValidation::class, 'prop');
+        $attributes = $reflection->getAttributes(Predicate::class);
+
+        $this->assertCount(1, $attributes);
+
+        $rule = $attributes[0]->newInstance();
+        $this->assertTrue($rule->isValid('user@example'));
+        $this->assertFalse($rule->isValid('invalid-prop'));
+    }
+
+    public function test_closure_validation_passes(): void
+    {
+        $rule = new Predicate(static fn (mixed $value): bool => str_contains((string) $value, '@'));
+        $this->assertTrue($rule->isValid('user@example.com'));
+        $this->assertTrue($rule->isValid('test@domain.org'));
+    }
+
+    public function test_closure_validation_fails(): void
+    {
+        $rule = new Predicate(static fn (mixed $value): bool => str_contains((string) $value, '@'));
+
+        $this->assertFalse($rule->isValid('username'));
+        $this->assertFalse($rule->isValid('example.com'));
+    }
+
+    public function test_non_string_value_fails(): void
+    {
+        $rule = new Predicate(static fn (mixed $value): bool => str_contains((string) $value, '@'));
+
+        $this->assertFalse($rule->isValid(12345));
+        $this->assertFalse($rule->isValid(null));
+        $this->assertFalse($rule->isValid(false));
+    }
+
+    public function test_static_closure_required(): void
+    {
+        $this->expectException(\InvalidArgumentException::class);
+
+        new Predicate(fn (mixed $value): bool => str_contains((string) $value, '@'));
+    }
+}