Merge pull request #2 from theo546/np0tju-codex/moderniser-le-code-pour-minecraft-1.21.6

Modernize plugin for Paper 1.21

Author: theo546

.github/workflows/release.yml

@@ -20,6 +20,15 @@ jobs:
         run: |
           VERSION=$(awk -F\" '/^version:/ {print $2}' RandomDrop/src/main/resources/plugin.yml)
           echo "version=$VERSION" >> "$GITHUB_OUTPUT"
+      - name: Delete existing release
+        env:
+          GH_TOKEN: ${{ secrets.GITHUB_TOKEN }}
+        run: |
+          TAG=${{ steps.version.outputs.version }}
+          if gh release view "$TAG" >/dev/null 2>&1; then
+            gh release delete "$TAG" -y
+            gh api -X DELETE "repos/${{ github.repository }}/git/refs/tags/$TAG"
+          fi
       - name: Build
         run: mvn -B -f RandomDrop/pom.xml package
       - name: Release

.gitignore

@@ -1 +1,2 @@
-server.jar
+server.jar
+target/

README.md

@@ -1,18 +1,24 @@
+<p align="center">
+  <img src="logo.svg" width="120" alt="RandomDrop logo" />
+</p>
+
 # RandomDrop
-is a plugin to randomize the items you are normally supposed to get when an item entity drop.
 
-This plugin now targets Paper 1.21.6.
+RandomDrop is a Minecraft plugin that replaces every drop with a deterministic random item. The project targets **Paper 1.21.6** and is intended to be dropped straight into your server's `plugins` folder.
+
+## Building from source
+
+```bash
+mvn -f RandomDrop/pom.xml package
+```
 
-This plugin has been inspired by a French Minecraft video series, but since the maker of the plugin wasn't willing to share it I just decided to make an identical one to share for the public.
+The compiled JAR will appear in `RandomDrop/target/`. If you are working inside a Codex environment you may need to configure the Maven proxy as documented below.
 
-# How to build?
-Clone the repository using git and run `mvn package` inside the `RandomDrop` directory to build the plugin JAR. The resulting file can be dropped directly into your server's `plugins` folder.
-If you are running in a Codex workspace you may need to configure Maven to use
-the built-in proxy before running the build command:
+### Using the Codex Maven proxy
 
-```sh
+```bash
 mkdir -p ~/.m2
-cat > ~/.m2/settings.xml <<EOF
+cat > ~/.m2/settings.xml <<'SETTINGS'
 <settings>
   <proxies>
     <proxy>
@@ -31,41 +37,22 @@ cat > ~/.m2/settings.xml <<EOF
     </proxy>
   </proxies>
 </settings>
-EOF
+SETTINGS
 ```
-When the `main` branch is updated, GitHub Actions automatically builds the plugin and publishes a release. The tag is derived from the `version` field in `plugin.yml`.
-
-## Configuration
-The configuration file is located in the `RandomDrop` folder inside the `plugins` folder of your Minecraft server, the file you are supposed to edit is `config.yml`.
-
-### RANDOMIZE_DURABILITY
-    (default: false)
-is to randomize the durability of a randomized item IF the item is damageable.
-
-### RANDOMIZE_DURABILITY_OF_CRAFTED_ITEMS
-    (default: false)
-is to randomize the durability of a crafted item IF the item is damageable.
-
-### CLAIMED_LORE_TEXT
-    (default: §r§7§lCLAIMED)
-is to change the randomized item lore.
 
-### SEED
-    (default: random_int)
-is to make the randomized items different for each seed, ex: seed 1234, if sand is broken, will loot iron - seed 1233, if sand is broken, will loot gold. To regenerate a random seed, delete the line. The seed is generated using the `System.currentTimeMillis();` function.
+## Continuous delivery
 
-### KEEP_ENCHANT_ON_DROPPED_UNCLAIMED_ITEM
-    (default: false)
-will, as its name imply, once the unclaimed item is drop, keep the enchant of the unclaimed item to the randomized item.
+Whenever `main` is updated, GitHub Actions builds the plugin and publishes a release. If a release with the same tag already exists, it is removed before uploading the new artifact.
 
-### KEEP_ITEM_CUSTOMNAME_ON_RANDOMIZE
-    (default: false)
-will, as its name imply, once the unclaimed item is drop, keep the custom name of the unclaimed item to the randomized item.
+## Configuration options
 
-### CLAIM_CRAFTED_ITEMS
-    (default: true)
-will, as its name imply, claim the item that is gonna be crafted.
+The configuration file is generated inside `plugins/RandomDrop/config.yml`. Notable options include:
 
-### RANDOMIZE_CRAFT
-    (default: false)
-will randomize the result item from a crafting table. However, it will not randomize the recipe.
+- **RANDOMIZE_DURABILITY** – randomize durability of dropped items (default: `false`)
+- **RANDOMIZE_DURABILITY_OF_CRAFTED_ITEMS** – randomize durability of crafted items (default: `false`)
+- **CLAIMED_LORE_TEXT** – lore line used to mark claimed items (default: `§r§7§lCLAIMED`)
+- **SEED** – controls the drop mapping; leave blank to regenerate (default: random value)
+- **KEEP_ENCHANT_ON_DROPPED_UNCLAIMED_ITEM** – keep enchantments when an item is randomized (default: `false`)
+- **KEEP_ITEM_CUSTOMNAME_ON_RANDOMIZE** – keep custom names when an item is randomized (default: `false`)
+- **CLAIM_CRAFTED_ITEMS** – mark crafted items as claimed (default: `true`)
+- **RANDOMIZE_CRAFT** – randomize crafting outputs (default: `true`)

RandomDrop/src/main/java/com/theo546/randomdrop/Listener.java

@@ -22,8 +22,12 @@ public void onItemSpawn(ItemSpawnEvent event) {
 
         if (itemstack.hasItemMeta()) {
             ItemMeta meta = itemstack.getItemMeta();
-            if (meta != null && meta.hasLore() && meta.getLore().contains(Main.CLAIMED_LORE_TEXT)) {
-                return;
+            if (meta != null && meta.hasLore()) {
+                for (String line : meta.getLore()) {
+                    if (line.equals(Main.CLAIMED_LORE_TEXT)) {
+                        return;
+                    }
+                }
             }
         }
 

RandomDrop/src/main/java/com/theo546/randomdrop/Main.java

@@ -32,7 +32,7 @@ public void onEnable() {
         getConfig().addDefault("KEEP_ENCHANT_ON_DROPPED_UNCLAIMED_ITEM", false);
         getConfig().addDefault("KEEP_ITEM_CUSTOMNAME_ON_RANDOMIZE", false);
         getConfig().addDefault("CLAIM_CRAFTED_ITEMS", true);
-        getConfig().addDefault("RANDOMIZE_CRAFT", false);
+        getConfig().addDefault("RANDOMIZE_CRAFT", true);
         getConfig().options().copyDefaults(true);
         saveConfig();