Skip to content

Commit bb9d833

Browse files
authored
updated readme (#90)
* updated readme * ci: removed paths-ignore
1 parent 7b7ea9c commit bb9d833

File tree

2 files changed

+26
-24
lines changed

2 files changed

+26
-24
lines changed

.github/workflows/CI.yml

Lines changed: 3 additions & 3 deletions
Original file line numberDiff line numberDiff line change
@@ -2,9 +2,9 @@ name: CI
22
on:
33
pull_request:
44
branches: [main]
5-
paths-ignore:
6-
- '**.md'
7-
- 'docs/**'
5+
# paths-ignore:
6+
# - '**.md'
7+
# - 'docs/**'
88

99
jobs:
1010
test:

README.md

Lines changed: 23 additions & 21 deletions
Original file line numberDiff line numberDiff line change
@@ -234,7 +234,7 @@ div.appendChild(table) // the table is added to the DOM
234234
| Feature | sortable.js | sortable.js + sortable.a11y.js | sortable.auto.js |
235235
| ------------------- | -------------------- | ------------------------------ | --------------------- |
236236
| Basic sorting ||||
237-
| Size | 1.71K (899B gzipped) | ~2.6K combined | 2.91K (1.30K gzipped) |
237+
| Size | 1.71K (899B gzipped) | ~2.7K combined | 3.04K (1.36K gzipped) |
238238
| Accessibility ||||
239239
| Auto-initialization ||||
240240
| Mutation observer ||||
@@ -646,42 +646,44 @@ Just set `aria-sort="descending"` or `aria-sort="ascending"` on the column you w
646646
</table>
647647
```
648648

649-
## Thank you...
649+
## Thank you 🙏
650650

651-
- ...[Nikita Dunajevs](https://github.com/dunajevs) for the [ascending sort](#ascending-sort) idea!
651+
- [Nikita Dunajevs](https://github.com/dunajevs) for the [ascending sort](#ascending-sort) idea!
652652

653-
- ...[wodny](https://github.com/wodny) for the [alternative sorting](#alternative-sorting) idea!
653+
- [wodny](https://github.com/wodny) for the [alternative sorting](#alternative-sorting) idea!
654654

655-
- ...[Nick Kocharhook](https://github.com/nk9) for the [colspan sorting](#colspanssort-on-specific-column) idea!
655+
- [Nick Kocharhook](https://github.com/nk9) for the [colspan sorting](#colspanssort-on-specific-column) idea!
656656

657-
- ...[mxve](https://github.com/mxve) for the **nested elements** inside `th` fix!
657+
- [mxve](https://github.com/mxve) for the **nested elements** inside `th` fix!
658658

659-
- ...[Christian Petersson](https://github.com/Issen007) and [Abit Salihu](https://github.com/abitsalihu) for the [sort on load](#sort-on-load) example!
659+
- [Christian Petersson](https://github.com/Issen007) and [Abit Salihu](https://github.com/abitsalihu) for the [sort on load](#sort-on-load) example!
660660

661-
- ...[GazHay](https://github.com/gazhay) for the idea to sort multiple `<tbody />`!
661+
- [GazHay](https://github.com/gazhay) for the idea to sort multiple `<tbody />`!
662662

663-
- ...[Gordan Ratkovic](https://github.com/GordanRatkovic) for the [tiebreaker / secondary sort](#tiebreaker--secondary-sort) idea!
663+
- [Gordan Ratkovic](https://github.com/GordanRatkovic) for the [tiebreaker / secondary sort](#tiebreaker--secondary-sort) idea!
664664

665-
- ...[chatcoda](https://github.com/chatcoda) for the `<td></td>` / `<td>0</td>` sorting bug fix!
665+
- [chatcoda](https://github.com/chatcoda) for the `<td></td>` / `<td>0</td>` sorting bug fix!
666666

667-
- ...[Christian Garbs](https://github.com/mmitch) for fixing the `dataset` bug!
667+
- [Christian Garbs](https://github.com/mmitch) for fixing the `dataset` bug!
668668

669-
- ...[Witold Baryluk](https://github.com/baryluk) for pointing out some inefficiencies!
669+
- [Witold Baryluk](https://github.com/baryluk) for pointing out some inefficiencies!
670670

671-
- ...[Nick](https://github.com/data-handler) for raising a whole bunch of issues! 🤯️
671+
- [Nick](https://github.com/data-handler) for raising a whole bunch of issues! 🤯️
672672

673-
- ...[James Pudson](https://github.com/nepsilon) for the [empty last](#emptynull-rows-always-last) suggestion, AND for finding the "`data-sort` ignored when empty" bug! 🥳️
673+
- [James Pudson](https://github.com/nepsilon) for the [empty last](#emptynull-rows-always-last) suggestion, AND for finding the "`data-sort` ignored when empty" bug! 🥳️
674674

675-
- ...[Jojo-IO](https://github.com/Jojo-IO) for the finding the "`parseFloat` messes up time values" bug!
675+
- [Jojo-IO](https://github.com/Jojo-IO) for the finding the "`parseFloat` messes up time values" bug!
676676

677-
- ...[Steve Wirt](https://github.com/swirtSJW) for lifting the Accessibility issue! 🦾️
677+
- [Steve Wirt](https://github.com/swirtSJW) for lifting the Accessibility issue! 🦾️
678678

679-
- ...[GazHay](https://github.com/gazhay) for the [sort events](#sort-events) idea!
679+
- [GazHay](https://github.com/gazhay) for the [sort events](#sort-events) idea!
680680

681-
- ...[deverac](https://github.com/deverac) for the empty `tr` bug fix!
681+
- [deverac](https://github.com/deverac) for the empty `tr` bug fix!
682682

683-
- ...[Richard Davies](https://github.com/RichardDavies) for nudging me into adding the "auto" version/flavour!
683+
- [Richard Davies](https://github.com/RichardDavies) for nudging me into adding the "auto" version/flavour!
684684

685-
- ...[fiskhandlarn](https://github.com/fiskhandlarn) for finding the whitespace bug!
685+
- [fiskhandlarn](https://github.com/fiskhandlarn) for finding the whitespace bug!
686686

687-
- ...[roxasthenobody98](https://github.com/roxasthenobody98) for the time sorting suggestion!
687+
- [roxasthenobody98](https://github.com/roxasthenobody98) for the time sorting suggestion!
688+
689+
- [Troy Morehouse](https://github.com/tmorehouse) for finding the 'A11Y labels still appear on TH when class "no-sort" is set' bug!

0 commit comments

Comments
 (0)