Skip to content

Cannot go back using alchemist-goto-jump-back(M-,). #376

@wettoast4

Description

@wettoast4

Phenomenon:
After jumping to a different location using 'M-.' (alchemist-goto-definition-at-point), I expected that 'M-,' would restore the original location, but the minibuffer displayed 'At start of xref history'.

Suggested solution:
This seems to be related to that 'find-tag-marker-ring' function is obsolete (Obsolete in Emacs 25.1, released in Sep 2016 ). I think the following fix to the lines 140 and 222 in bodies of 'alchemist-goto-list-symbol-definitions' and 'alchemist-goto--open-definition' functions in alchemist-goto.el will get it work. But I'm not confident if this modification does not affect other parts because I have less experience on ELISP language. Please point out if I'm wrong.

before fix: (ring-insert find-tag-marker-ring (point-marker))
after fix: (xref-push-marker-stack (point-marker))

versions I used:

  • Alchemist version: 1.8.2 (package: 20180312.1304)
  • Emacs version: GNU Emacs 29.4 (build 1, x86_64-pc-linux-gnu, GTK+ Version 3.24.42, cairo version 1.18.0)

Metadata

Metadata

Assignees

No one assigned

    Labels

    No labels
    No labels

    Projects

    No projects

    Milestone

    No milestone

    Relationships

    None yet

    Development

    No branches or pull requests

    Issue actions